flush SO_SNDBUF data on every send and deprecate send_bytes #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Currently I deprecated
send_bytesand it only affects the decision to flush but not how much to flush. Alternative options include:Remove the setting entirely and emit an error.
Remove the setting but allow it and emit a
UserWarningtriggering people to remove it from their settings.Do not deprecate the setting and just define it as only affecting when to flush but not how much. Change the default to 1.
I propose keeping it like I did in the PR and then removing it in waitress 2.0 along with the trusted proxy backward-incompatible changes.