Skip to content

Conversation

@mmerickel
Copy link
Member

Fixes comments in #243 (comment).

  1. A warning will now be emitted if a bunch of tasks are submitted while there is an idle thread, before the threads pop the jobs, because we know that when they pop them there will still be too many.
  2. Greatly simplified the shutdown logic on the threads to use only stop_count and get rid of the tombstoned None task.
  3. Shutdown now uses a condition to exit every so slightly faster when all threads are complete by having each dying thread notify.
  4. Added a warning on shutdown if any tasks are canceled.

@mmerickel mmerickel force-pushed the idle-warning-redux-2 branch from 1c91040 to c1b681d Compare April 5, 2019 16:19
@digitalresistor digitalresistor merged commit 5bd69e9 into master Apr 5, 2019
@digitalresistor digitalresistor deleted the idle-warning-redux-2 branch April 5, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants