Skip to content

Conversation

@oscard0m
Copy link
Contributor

@oscard0m oscard0m commented Jul 5, 2021

Description

Add cache to workflows using actions/setup-node

Context

setup-node GitHub Action just released a new option to add cache to steps using it.

You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/

Fix #1153


🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾

@waylan
Copy link
Member

waylan commented Jul 5, 2021

There is way to many changes to whitespace here that I can't even see what the substantive change was. If the whitespace changes are removed, I'll be happy to review.

@waylan waylan added the requires-changes Awaiting updates after a review. label Jul 5, 2021
@oscard0m
Copy link
Contributor Author

oscard0m commented Jul 5, 2021

There is way to many changes to whitespace here that I can't even see what the substantive change was. If the whitespace changes are removed, I'll be happy to review.

You can see the changes without whitespaces in this link: https://github.com/Python-Markdown/markdown/pull/1152/files?diff=unified&w=1

If still is noisy I can remove those whitespaces (it's the result of running prettier to the file but I can remove these indentations if you want)

@waylan
Copy link
Member

waylan commented Jul 6, 2021

If still is noisy I can remove those whitespaces (it's the result of running prettier to the file but I can remove these indentations if you want)

Yes, please do.

@waylan waylan merged commit 6f024f5 into Python-Markdown:master Jul 6, 2021
@waylan waylan mentioned this pull request Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-changes Awaiting updates after a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

To add cache to workflows using actions/setup-node

2 participants