Skip to content

Conversation

@facelessuser
Copy link
Collaborator

@facelessuser facelessuser commented Apr 5, 2020

Not sure how tests didn't get run on this, but it was completely
breaking all a lot of tests. This reverts the change.

Fixes #932

Not sure how tests didn't get run on this, but it was completely
breaking all tests. This reverts the change.
@facelessuser
Copy link
Collaborator Author

Spellchecker is finding lt in code blocks, that is why the spellchecker is failing. Not sure how you want us to handle this @waylan. Do I just add lt to the dictionary? Or can we exclude code tags?

@waylan
Copy link
Member

waylan commented Apr 6, 2020

Weird. I distantly recall checking that the tests passed on that because I expected them to fail. When the weren't failing, I accepted the change. But now, looking back, I don't see any indication that any tests even ran. Not sure what happened there. In any event we're getting 60 failing tests so this is the right move.

Also I just noticed that the note was added to the release notes for a previous release rather than a future release. Guess I wasn't paying close attention that day.

Spellchecker is finding lt in code blocks,

Code blocks are supposed to be skipped already. Not sure why that isn't happening.

@facelessuser
Copy link
Collaborator Author

@waylan #934 fixes it, it was finding the lt in the TOC.

@waylan waylan merged commit 7c595e2 into Python-Markdown:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Last commit breaks a bunch of tests

2 participants