-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Env variable to disable specific browser in generate_config of Node/Standalone all-browsers #3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…f Node/Standalone all-browsers Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Add environment variable
SE_NODE_ENABLE_BROWSER_<BROWSER>to disable specific browsersAllow selective browser installation in Node/Standalone all-browsers images
Document supported environment variable suffixes for browser configuration
Enable skipping browser stereotype generation when disabled
Diagram Walkthrough
flowchart LR A["Browser Directory Loop"] --> B["Assign Browser-Specific Env Vars"] B --> C{"SE_NODE_ENABLE_BROWSER<br/>== false?"} C -->|Yes| D["Skip Browser Setup"] C -->|No| E["Generate Stereotype"] D --> F["Continue to Next Browser"] E --> FFile Walkthrough
generate_config
Add browser disable logic to generate_config scriptNodeBase/generate_config
SE_NODE_ENABLE_BROWSERto theENV_PREFIXESarray for environmentvariable processing
when
SE_NODE_ENABLE_BROWSERis set tofalsewhen disabled
README.md
Document browser disable environment variable featureREADME.md
SE_NODE_ENABLE_BROWSER_environment variablefunctionality
all-browsers images
linux/arm64)