[dotnet] Future-proof for NUnit 4.x upgrade

[RenderMichael]

Feature and motivation

With the release of NUnit 4.x, a few major breaking changes have been added. We want our test suite to be able to be prepared for NUnit 4, even if we're not going to upgrade for a while yet.

• Classic Assert [dotnet] Migrate NUnit assertions to Assert.That syntax #14853 [dotnet] Migrate remaining NUnit assertions to Assert.That and Has.Count #14870
  The "classic assert" model has been depreciated. In order to continue using them, the tests would need to jump through some hoops.

  A better solution would be to migrate to modern NUnit assertions. The NUnit.Analyzers nuget package has useful features to accomplish this. Examples include:

  • Assert.AreEqual("Testing Alerts", driver.Title) -> Assert.That(driver.Title, Is.EqualTo("Testing Alerts"))
  • Assert.AreEqual(1, allWindows.Count) -> Assert.That(allWindows, Has.One.Items)

• String format messages [dotnet] Correct assertion of struct type in internal tests #14878
  NUnit 3.x has methods such as Assert.That(x, Is.EqualTo(y), "Value {0} is {1}", x, y). These overloads have been removed, in order to make room for caller argument expression parameters. We will have to go through and turn these all into interpolated strings. Same For Assert.Ignore(string message, string[] args).

• The handful of uses of StringAssert or CollectionAssert should be changed to Assert.That. [dotnet] Migrate remaining NUnit assertions to Assert.That and Has.Count #14870

[github-actions]

@RenderMichael, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[nvborisenko]

Thanks, it is good initiative.

PS: I edited the goal to be achievable.

[nvborisenko]

@RenderMichael Will it make sense to create one big PR? I will approve changes like Assert.Equal(...) -> Assert.That(...).

[RenderMichael]

@nvborisenko I can make a massive PR, if that's preferable. I'll start adding more changes to #14853

[nvborisenko]

If we can agree some rules before big boom. I expect ONLY Assert.That(...), no more new constructions (like Assert.Multiple).

[RenderMichael]

The PR which migrates us to Assert.That is ready.

However, there are a few other things which block NUnit 4.x besides that. For example, the (..., string message, params string[] args) has been removed. I will have to go over a few other things after the big PR lands. Can this issue be renamed to something like "prepare for NUnit 4"?

[github-actions]

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.