-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[java] [dotnet] Add move to location method to Actions #11509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #11509 +/- ##
=======================================
Coverage 57.11% 57.11%
=======================================
Files 86 86
Lines 5365 5365
Branches 193 193
=======================================
Hits 3064 3064
Misses 2108 2108
Partials 193 193 ☔ View full report in Codecov by Sentry. |
|
SonarCloud Quality Gate failed. |
e563527 to
209f329
Compare
|
force pushing a rebased update; the new Java formatting updates made it easier to do it this way. Evaluating now. |
|
@diemol which of these does it make more sense to support? It feels like we should be picking the "right" one and have people use it rather than supporting two options? Action moveAndClick = getBuilder(driver).moveToLocation(70, 60).click().build();and Action moveAndClick = getBuilder(driver).moveToLocation(new Point(70, 60)).click().build();Also, my default for multiple constructors or methods that do the same thing with different parameters is that one should call the other rather than be a re-implementation. So one way or the other I think this PR needs to be tweaked slightly. .NET looks good; don't have .NET environment working on new laptop yet, though. |
|
Hmm .NET test is failing in CI... Passing in my fresh .NET dev environment; probably a timing issue; trying the equivalent test from Ruby. |
|
This one might be "easier"? Action moveAndClick = getBuilder(driver).moveToLocation(70, 60).click().build(); |
|
Java looks good, but .NET + Windows + Firefox isn't happy and I'll have to load up a VM to troubleshoot it. |
0dc89a2 to
a220aa5
Compare
a220aa5 to
8514aa9
Compare








Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add move to location method to Actions class
Motivation and Context
Explained in #10724. The change implement proposal 2.
Types of changes
Checklist