Skip to content

Conversation

@pujagani
Copy link
Contributor

@pujagani pujagani commented Jan 4, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add move to location method to Actions class

Motivation and Context

Explained in #10724. The change implement proposal 2.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani added the C-java Java Bindings label Jan 4, 2023
@pujagani pujagani changed the title [java] Add move to location method to Actions [java] [dotnet] Add move to location method to Actions Jan 4, 2023
@pujagani pujagani added the C-dotnet .NET Bindings label Jan 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4468622) 57.11% compared to head (2755531) 57.11%.

❗ Current head 2755531 differs from pull request most recent head 8514aa9. Consider uploading reports for the commit 8514aa9 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11509   +/-   ##
=======================================
  Coverage   57.11%   57.11%           
=======================================
  Files          86       86           
  Lines        5365     5365           
  Branches      193      193           
=======================================
  Hits         3064     3064           
  Misses       2108     2108           
  Partials      193      193           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@titusfortner titusfortner added this to the 4.9 milestone Jan 14, 2023
@diemol diemol modified the milestones: 4.9, 4.10 Apr 17, 2023
@titusfortner titusfortner self-assigned this May 18, 2023
@titusfortner titusfortner force-pushed the add-move-to-location branch from e563527 to 209f329 Compare May 31, 2023 02:31
@titusfortner
Copy link
Member

force pushing a rebased update; the new Java formatting updates made it easier to do it this way. Evaluating now.

@titusfortner
Copy link
Member

@diemol which of these does it make more sense to support? It feels like we should be picking the "right" one and have people use it rather than supporting two options? Point isn't being used anywhere else, but everything else is offsets not something that represents coordinates on the viewport, so it might be more correct...

    Action moveAndClick = getBuilder(driver).moveToLocation(70, 60).click().build();

and

    Action moveAndClick = getBuilder(driver).moveToLocation(new Point(70, 60)).click().build();

Also, my default for multiple constructors or methods that do the same thing with different parameters is that one should call the other rather than be a re-implementation. So one way or the other I think this PR needs to be tweaked slightly.

.NET looks good; don't have .NET environment working on new laptop yet, though.

@titusfortner
Copy link
Member

Hmm .NET test is failing in CI... Passing in my fresh .NET dev environment; probably a timing issue; trying the equivalent test from Ruby.

@diemol
Copy link
Member

diemol commented May 31, 2023

This one might be "easier"?

Action moveAndClick = getBuilder(driver).moveToLocation(70, 60).click().build();

@titusfortner
Copy link
Member

Java looks good, but .NET + Windows + Firefox isn't happy and I'll have to load up a VM to troubleshoot it.

@titusfortner titusfortner modified the milestones: 4.10, 4.11 Jun 6, 2023
@titusfortner titusfortner removed this from the 4.11 milestone Jun 27, 2023
@titusfortner titusfortner force-pushed the add-move-to-location branch 2 times, most recently from 0dc89a2 to a220aa5 Compare July 11, 2023 17:13
@titusfortner titusfortner force-pushed the add-move-to-location branch from a220aa5 to 8514aa9 Compare July 11, 2023 18:56
@titusfortner titusfortner merged commit 8472410 into SeleniumHQ:trunk Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-dotnet .NET Bindings C-java Java Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants