-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Allow setting a different pointer, keyboard, or wheel on input device #11513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aab1520 to
71fe796
Compare
|
One interesting side effect of this implementation is that devices aren't created by default when class is loaded, but lazily generated (which is what Ruby does and I like it)... but I can't remember how it works to create a new device from the last time I was in the .NET actions code. If we've taken keyboard actions and then create a new pointer device, does it create an array of the size of the keyboard device actions list and add pauses, or will the first pointer action happen at the same time as the first keyboard action? I'm not sure if we have a test covering this use case, and if not we need to add them. |
71fe796 to
a08b14d
Compare
|
Thank you for taking a look. I am not very familiar with the actions code. I am digging into it and will provide more information. I don't think the test exists for the use case mentioned, I think adding it will help me answer your question. |
|
"If we've taken keyboard actions and then create a new pointer device, does it create an array of the size of the keyboard device actions list and add pauses" - Based on debugging and my understanding, this is what is happening. I have also added a test to confirm the same. Is that the expected behavior? @titusfortner |
afa8f16 to
88ba81d
Compare
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #11513 +/- ##
=======================================
Coverage 57.11% 57.11%
=======================================
Files 86 86
Lines 5365 5365
Branches 193 193
=======================================
Hits 3064 3064
Misses 2108 2108
Partials 193 193 ☔ View full report in Codecov by Sentry. |
88ba81d to
16c09a2
Compare
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Allow setting a different pointer, keyboard, or wheel on input device without using Action builder
Motivation and Context
Related to proposal 1 described in #10724
Types of changes
Checklist