Skip to content

Conversation

@nvborisenko
Copy link
Member

Description

async void is not good approach - unhandled exceptions will crash entire app.

Motivation and Context

Fixes #12480

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol
Copy link
Member

diemol commented Aug 4, 2023

Build is failing.

@titusfortner titusfortner added this to the 4.12 milestone Aug 14, 2023
@titusfortner titusfortner merged commit 074e7c8 into SeleniumHQ:trunk Aug 14, 2023
@titusfortner
Copy link
Member

I'm so glad we fixed the .NET build finally 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Entire application crash in case of unhandled exception in async void method

3 participants