You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Complexity The BrowsingContextModule class contains a large number of methods and responsibilities. Consider breaking it down into smaller, more focused classes to improve maintainability and readability.
Error Handling The error handling in the ReceiveMessagesAsync method could be improved. Consider adding more specific exception handling and logging to better diagnose and handle potential issues.
Type Conversion The ConvertTo method uses a switch statement for type conversion. This approach might not be extensible enough for future types. Consider implementing a more flexible conversion strategy.
Add error handling in DisposeAsync to ensure robust resource cleanup
Implement error handling for DisposeAsync to manage exceptions that might occur during the disposal process, ensuring all resources are cleaned up properly.
-await EndAsync().ConfigureAwait(false);+try+{+ await EndAsync().ConfigureAwait(false);+}+catch (Exception ex)+{+ // Log the exception or handle it accordingly+}
Apply this suggestion
Suggestion importance[1-10]: 10
Why: Implementing error handling in DisposeAsync is critical for ensuring that all resources are cleaned up properly, even if an exception occurs, thus improving the robustness of the code.
10
Add exception handling for the command execution in the 'CreateAsync' method
In the CreateAsync method, consider handling exceptions that may occur during the execution of Broker.ExecuteCommandAsync. This can improve the robustness of the method by allowing it to gracefully handle scenarios where the command execution fails.
-var createResult = await Broker.ExecuteCommandAsync<CreateResult>(new CreateCommand(@params), options).ConfigureAwait(false);+CreateResult createResult;+try+{+ createResult = await Broker.ExecuteCommandAsync<CreateResult>(new CreateCommand(@params), options).ConfigureAwait(false);+}+catch (Exception ex)+{+ // Handle exception (e.g., log the error, modify the response)+ throw new InvalidOperationException("Failed to create browsing context.", ex);+}
Apply this suggestion
Suggestion importance[1-10]: 8
Why: Adding exception handling enhances the robustness of the method by allowing it to handle failures gracefully. This is a valuable improvement for error management.
8
Bug fix
Correct the syntax for initializing collections
Replace the array initializer with a proper collection initializer to avoid syntax errors.
public static KeySourceActions Press(string text)
+{+ if (text == null) throw new ArgumentNullException(nameof(text));
Apply this suggestion
Suggestion importance[1-10]: 10
Why: Adding null checks is crucial to prevent potential runtime exceptions, making this a highly valuable suggestion for improving code robustness.
10
Enhancement
Add validation for the 'url' parameter to ensure it is a well-formed URL
Consider validating the url parameter in the NavigateAsync method to ensure it is a well-formed URL before proceeding with the navigation command. This can prevent potential errors or security issues related to malformed URLs.
+if (!Uri.IsWellFormedUriString(url, UriKind.Absolute))+ throw new ArgumentException("The URL provided is not a valid absolute URL.", nameof(url));
var @params = new NavigateCommandParameters(context, url);
Apply this suggestion
Suggestion importance[1-10]: 9
Why: This suggestion adds a crucial validation step to ensure the URL is well-formed, which can prevent potential runtime errors and security issues. It is a significant improvement for robustness and security.
9
Improve URL validation by using Uri.TryCreate
Consider using Uri.TryCreate instead of new Uri to handle potential exceptions from invalid URLs gracefully.
-var uri = new Uri(url);+if (!Uri.TryCreate(url, UriKind.Absolute, out var uri))+{+ throw new ArgumentException("Invalid URL provided.", nameof(url));+}
Apply this suggestion
Suggestion importance[1-10]: 9
Why: This suggestion improves the robustness of the code by handling potential exceptions from invalid URLs gracefully, which is crucial for preventing runtime errors.
9
✅ Use null instead of default for clearer default parameter valuesSuggestion Impact:The commit changed the default parameter value of duration in the Pause method to null, which aligns with the suggestion. However, it also changed the type from ulong? to long?.
code diff:
- public KeySourceActions Pause(ulong? duration = default)+ public KeySourceActions Pause(long? duration = null)
Replace the default parameter value of duration in Pause method with null instead of default to make the intent clearer and align with common C# practices.
Why: This suggestion enhances code clarity and aligns with common C# practices, although it is a minor improvement.
7
Implement a timeout mechanism for the 'ReloadAsync' method to handle long-running reloads
In the ReloadAsync method, consider adding a timeout option to the NavigateOptions and implement a timeout mechanism in the navigation process. This can prevent the method from waiting indefinitely if the page reload does not complete.
var @params = new ReloadCommandParameters(context);
+if (options?.Timeout.HasValue)+{+ @params.Timeout = options.Timeout.Value;+}
Apply this suggestion
Suggestion importance[1-10]: 6
Why: Implementing a timeout mechanism is a good enhancement to prevent indefinite waiting during page reloads. However, it is a less critical improvement compared to the others.
6
Possible issue
Replace mutable default value with an immutable one to avoid side effects
Replace the mutable default value for Actions in PerformActionsOptions with a more appropriate immutable default. Using mutable default values can lead to unintended side effects if the same instance is reused.
Why: The suggestion correctly identifies a potential issue with using a mutable default value and provides a more appropriate immutable default, which can prevent unintended side effects.
9
Validate the 'Clip' property to ensure it is within the viewport bounds in 'CaptureScreenshotAsync'
For the CaptureScreenshotAsync method, consider checking if the Clip property of the options is within the bounds of the current viewport. This can prevent runtime errors or undefined behavior when the clipping region is out of the viewport bounds.
var @params = new CaptureScreenshotCommandParameters(context);
+if (options?.Clip != null && !IsValidClip(options.Clip))+{+ throw new ArgumentException("Clip parameters are out of the viewport bounds.", nameof(options));+}
Apply this suggestion
Suggestion importance[1-10]: 7
Why: This suggestion adds a validation step to ensure the Clip property is within the viewport bounds, which can prevent potential runtime errors. It is a useful improvement for preventing undefined behavior.
7
Best practice
Implement IDisposable to manage resource cleanup
Implement IDisposable to properly dispose of Lazy fields if they hold unmanaged resources or need explicit disposal.
-private readonly Lazy<BrowsingContextLogModule> _logModule;-private readonly Lazy<BrowsingContextNetworkModule> _networkModule;-private readonly Lazy<BrowsingContextScriptModule> _scriptModule;-private readonly Lazy<BrowsingContextStorageModule> _storageModule;-private readonly Lazy<BrowsingContextInputModule> _inputModule;+public void Dispose()+{+ if (_logModule.IsValueCreated) _logModule.Value.Dispose();+ if (_networkModule.IsValueCreated) _networkModule.Value.Dispose();+ if (_scriptModule.IsValueCreated) _scriptModule.Value.Dispose();+ if (_storageModule.IsValueCreated) _storageModule.Value.Dispose();+ if (_inputModule.IsValueCreated) _inputModule.Value.Dispose();+}
Apply this suggestion
Suggestion importance[1-10]: 8
Why: Implementing IDisposable is a best practice for managing resource cleanup, especially if the Lazy<T> fields hold unmanaged resources or need explicit disposal.
8
Use IReadOnlyList to ensure immutability of the Actions list
Consider using IReadOnlyList instead of List for the Actions property in KeySourceActions to ensure immutability and to prevent external modifications.
-return TraverseHistoryAsync(-1, options);-return TraverseHistoryAsync(1, options);+const int BACK = -1;+const int FORWARD = 1;+return TraverseHistoryAsync(BACK, options);+return TraverseHistoryAsync(FORWARD, options);
Apply this suggestion
Suggestion importance[1-10]: 6
Why: Replacing magic numbers with named constants improves code readability and maintainability. However, the improvement is minor and does not address any critical issue.
6
Performance
✅ Use ConfigureAwait(false) for better performance in asynchronous operations
Utilize ConfigureAwait(false) on all awaited operations within ConnectAsync to ensure the context is not captured, improving performance in environments that do not require the context.
Why: This suggestion enhances performance in asynchronous operations by ensuring the context is not captured, which is beneficial in environments that do not require the context.
8
Maintainability
Use a factory method to initialize Lazy fields
Consider using a factory method to initialize the Lazy fields to reduce redundancy and improve maintainability. This will help centralize the creation logic and make the code cleaner.
-_logModule = new Lazy<BrowsingContextLogModule>(() => new BrowsingContextLogModule(this, _bidi.Log));-_networkModule = new Lazy<BrowsingContextNetworkModule>(() => new BrowsingContextNetworkModule(this, _bidi.Network));-_scriptModule = new Lazy<BrowsingContextScriptModule>(() => new BrowsingContextScriptModule(this, _bidi.ScriptModule));-_storageModule = new Lazy<BrowsingContextStorageModule>(() => new BrowsingContextStorageModule(this, _bidi.Storage));-_inputModule = new Lazy<BrowsingContextInputModule>(() => new BrowsingContextInputModule(this, _bidi.InputModule));+_logModule = CreateLazyModule<BrowsingContextLogModule>(_bidi.Log);+_networkModule = CreateLazyModule<BrowsingContextNetworkModule>(_bidi.Network);+_scriptModule = CreateLazyModule<BrowsingContextScriptModule>(_bidi.ScriptModule);+_storageModule = CreateLazyModule<BrowsingContextStorageModule>(_bidi.Storage);+_inputModule = CreateLazyModule<BrowsingContextInputModule>(_bidi.InputModule);+private Lazy<T> CreateLazyModule<T>(IModule module) where T : IModule+{+ return new Lazy<T>(() => (T)Activator.CreateInstance(typeof(T), new object[] { this, module }));+}+
Apply this suggestion
Suggestion importance[1-10]: 7
Why: The suggestion improves maintainability by reducing redundancy and centralizing the creation logic. However, it introduces additional complexity with the factory method.
* Migrate
* Use CLS compliant long instead of ulong
* Use null instead of default for optional arguments
* Use internal logging in websockettransport
* Use internal logger in broker
* Even with error log level
* Simplify AsBidirectionalContextAsync
* Fix ConfigureAwait in network module
* Hide direct network interception
* Rework public adding interception
* Simplify network interception
* Don't end session when disposing bidi driver
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qodo-code-review
bot
added
P-enhancement
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
User description
This is the implementation of BiDi protocol for .NET
Description
OpenQA.Selenium.BiDinamespaceMotivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
OpenQA.Selenium.BiDinamespace.BrowsingContextModulefor managing browsing contexts.Brokerclass for BiDi protocol communication.BrowsingContextclass for context management.RemoteValueclass and derived types for representing remote values.NetworkModulefor network-related operations.BiDiclass for protocol management.BrowsingContextNetworkModulefor network operations within a browsing context.Commandclass and derived types for representing commands.Interceptclass for network intercepts.ScriptModulefor script-related operations.LocalValueclass and derived types for representing local values.RemoteValueConverterfor JSON serialization ofRemoteValuetypes.RealmInfoclass and derived types for representing realm information.PerformActionsCommandfor performing input actions.WebSocketTransportfor WebSocket communication.BrowsingContextScriptModulefor script operations within a browsing context.PrintCommandfor printing a browsing context.GetCookiesCommandfor retrieving cookies.SessionModulefor session management.Locatorclass and derived types for locating elements.Requestclass for managing network requests.StorageModulefor storage-related operations.CaptureScreenshotCommandfor capturing screenshots.RealmInfoConverterfor JSON serialization ofRealmInfotypes.EventHandlerclass and derived types for handling events.EvaluateCommandfor evaluating scripts.BrowserModulefor browser operations.BrowsingContextStorageModulefor storage operations within a browsing context.RealmTypeConverterfor JSON serialization ofRealmTypeenum.UrlPatternclass and derived types for representing URL patterns.CallFunctionCommandfor calling functions.ProxyConfigurationclass and derived types for configuring proxies.Subscriptionclass for event management.LogEntryclass and derived types for representing log entries.ContinueResponseCommandfor continuing responses.ProvideResponseCommandfor providing responses.ContinueRequestCommandfor continuing requests.LogEntryConverterfor JSON serialization ofLogEntrytypes.ContinueWithAuthCommandfor continuing with authentication.EvaluateResultConverterfor JSON serialization ofEvaluateResulttypes.SetCookieCommandfor setting cookies.MessageConverterfor JSON serialization ofMessagetypes.LocateNodesCommandfor locating nodes.AddInterceptCommandfor adding intercepts.AddPreloadScriptCommandfor adding preload scripts.DateTimeOffsetConverterfor JSON serialization ofDateTimeOffset.InternalIdConverterfor JSON serialization.ChannelConverterfor JSON serialization.HandleConverterfor JSON serialization.RealmConverterfor JSON serialization.RequestConverterfor JSON serialization.GetRealmsCommandand related records.GetTreeCommandand related records.Messagerecords for communication.SetViewportCommandand related records.LogModulefor log entry subscriptions.NavigateCommandand related records.NewCommandand related records.PreloadScriptclass for managing preload scripts.NavigationConverterfor JSON serialization.HandleUserPromptCommandand related records.UserContextclass for managing user contexts.ReloadCommandand related records.ResponseDatarecord for network responses.SetCookieHeaderrecord for cookies.SubscribeCommandand related records.BrowsingContextInforecord for context info.Initiatorrecord and enum for network requests.DeleteCookiesCommandand related records.BrowsingContextInputModulefor input actions.UserPromptOpenedEventArgsandUserPromptTypeenum.BaseParametersEventArgsfor network events.BytesValueand derived records.Targetand derived records.CapabilityRequestclass for session capabilities.ScriptEvaluateExceptionclass.FetchTimingInforecord for network timings.Cookierecord andSameSiteenum.BeforeRequestSentEventArgsrecord.ITransportinterface for communication.ResponseCompletedEventArgsrecord.SerializationOptionsclass andShadowTreeenum.FetchErrorEventArgsrecord.ResponseStartedEventArgsrecord.TraverseHistoryCommandand related records.AuthCredentialsand derived records.EventArgsand derived records.RemovePreloadScriptCommandand related records.RemoveUserContextCommandand related records.AuthRequiredEventArgsrecord.RemoveInterceptCommandand related records.DisownCommandand related records.GetUserContextsCommandand related records.ChannelValueandChannelPropertiesrecords.RemoteReferenceand derived records.UserPromptClosedEventArgsrecord.ReleaseActionsCommandand related records.FailRequestCommandand related records.ActivateCommandand related records.CloseCommandand related records.InternalIdclass.Handleclass.Realmclass.Channelclass.RequestDatarecord for network requests.CapabilitiesRequestclass.StatusCommandand related records.RealmTypeenum for script realms.Changes walkthrough 📝
46 files
BrowsingContextModule.cs
Introduce BrowsingContextModule for managing browsing contextsdotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextModule.cs
BrowsingContextModuleclass with various methods formanaging browsing contexts.
browsing contexts.
events.
Broker.cs
Implement Broker class for BiDi protocol communicationdotnet/src/webdriver/BiDi/Communication/Broker.cs
Brokerclass for handling communication with the BiDiprotocol.
messages.
BrowsingContext.cs
Introduce BrowsingContext class for context managementdotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContext.cs
BrowsingContextclass representing a browsing context.context.
RemoteValue.cs
Define RemoteValue class and derived typesdotnet/src/webdriver/BiDi/Modules/Script/RemoteValue.cs
RemoteValueclass and its derived types for representingremote values.
NumberRemoteValue,StringRemoteValue, andObjectRemoteValue.NetworkModule.cs
Introduce NetworkModule for network operationsdotnet/src/webdriver/BiDi/Modules/Network/NetworkModule.cs
NetworkModuleclass for managing network-relatedoperations.
requests.
BiDi.cs
Implement BiDi class for protocol managementdotnet/src/webdriver/BiDi/BiDi.cs
BiDiclass for managing the BiDi protocol connection.getting context trees.
events.
BrowsingContextNetworkModule.cs
Introduce BrowsingContextNetworkModule for network operationsdotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextNetworkModule.cs
BrowsingContextNetworkModuleclass for managing networkoperations within a browsing context.
events.
Command.cs
Define Command class and derived typesdotnet/src/webdriver/BiDi/Communication/Command.cs
Commandclass and its derived types for representingcommands.
Session,Browser, andNetwork.Intercept.cs
Introduce Intercept class for network interceptsdotnet/src/webdriver/BiDi/Modules/Network/Intercept.cs
Interceptclass for managing network intercepts.events.
ScriptModule.cs
Introduce ScriptModule for script operationsdotnet/src/webdriver/BiDi/Modules/Script/ScriptModule.cs
ScriptModuleclass for managing script-related operations.LocalValue.cs
Define LocalValue class and derived typesdotnet/src/webdriver/BiDi/Modules/Script/LocalValue.cs
LocalValueclass and its derived types for representinglocal values.
NumberLocalValue,StringLocalValue, andObjectLocalValue.RemoteValueConverter.cs
Implement RemoteValueConverter for JSON serializationdotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/RemoteValueConverter.cs
RemoteValueConverterclass for JSON serialization ofRemoteValuetypes.RemoteValueobjects.RealmInfo.cs
Define RealmInfo class and derived typesdotnet/src/webdriver/BiDi/Modules/Script/RealmInfo.cs
RealmInfoclass and its derived types for representingrealm information.
WindowRealmInfo,WorkerRealmInfo, andServiceWorkerRealmInfo.PerformActionsCommand.cs
Define PerformActionsCommand and action typesdotnet/src/webdriver/BiDi/Modules/Input/PerformActionsCommand.cs
PerformActionsCommandclass and its parameters forperforming input actions.
KeyDownAction,KeyUpAction, andKeyPauseAction.WebSocketTransport.cs
Implement WebSocketTransport for WebSocket communicationdotnet/src/webdriver/BiDi/Communication/Transport/WebSocketTransport.cs
WebSocketTransportclass for managing WebSocketconnections.
BrowsingContextScriptModule.cs
Introduce BrowsingContextScriptModule for script operationsdotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextScriptModule.cs
BrowsingContextScriptModuleclass for managing scriptoperations within a browsing context.
PrintCommand.cs
Define PrintCommand and print optionsdotnet/src/webdriver/BiDi/Modules/BrowsingContext/PrintCommand.cs
PrintCommandclass and its parameters for printing abrowsing context.
orientation, and scale.
GetCookiesCommand.cs
Define GetCookiesCommand and optionsdotnet/src/webdriver/BiDi/Modules/Storage/GetCookiesCommand.cs
GetCookiesCommandclass and its parameters for retrievingcookies.
SessionModule.cs
Introduce SessionModule for session managementdotnet/src/webdriver/BiDi/Modules/Session/SessionModule.cs
SessionModuleclass for managing session-relatedoperations.
to events.
Locator.cs
Define Locator class and derived typesdotnet/src/webdriver/BiDi/Modules/BrowsingContext/Locator.cs
Locatorclass and its derived types for locating elements.CssLocator,XPathLocator, andInnerTextLocator.Request.cs
Introduce Request class for network requestsdotnet/src/webdriver/BiDi/Modules/Network/Request.cs
Requestclass for managing network requests.to requests.
StorageModule.cs
Introduce StorageModule for storage operationsdotnet/src/webdriver/BiDi/Modules/Storage/StorageModule.cs
StorageModuleclass for managing storage-relatedoperations.
CaptureScreenshotCommand.cs
Define CaptureScreenshotCommand and optionsdotnet/src/webdriver/BiDi/Modules/BrowsingContext/CaptureScreenshotCommand.cs
CaptureScreenshotCommandclass and its parameters forcapturing screenshots.
format, and clip.
RealmInfoConverter.cs
Implement RealmInfoConverter for JSON serializationdotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/RealmInfoConverter.cs
RealmInfoConverterclass for JSON serialization ofRealmInfotypes.RealmInfoobjects.EventHandler.cs
Define EventHandler class and derived typesdotnet/src/webdriver/BiDi/Communication/EventHandler.cs
EventHandlerclass and its derived types for handlingevents.
EvaluateCommand.cs
Define EvaluateCommand and result typesdotnet/src/webdriver/BiDi/Modules/Script/EvaluateCommand.cs
EvaluateCommandclass and its parameters for evaluatingscripts.
BrowserModule.cs
Introduce BrowserModule for browser operationsdotnet/src/webdriver/BiDi/Modules/Browser/BrowserModule.cs
BrowserModuleclass for managing browser-relatedoperations.
contexts.
BrowsingContextStorageModule.cs
Introduce BrowsingContextStorageModule for storage operationsdotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextStorageModule.cs
BrowsingContextStorageModuleclass for managing storageoperations within a browsing context.
RealmTypeConverter.cs
Implement RealmTypeConverter for JSON serializationdotnet/src/webdriver/BiDi/Communication/Json/Converters/RealmTypeConverter.cs
RealmTypeConverterclass for JSON serialization ofRealmTypeenum.RealmTypevalues.UrlPattern.cs
Define UrlPattern class and derived typesdotnet/src/webdriver/BiDi/Modules/Network/UrlPattern.cs
UrlPatternclass and its derived types for representingURL patterns.
UrlPatternPatternandUrlPatternString.CallFunctionCommand.cs
Define CallFunctionCommand and optionsdotnet/src/webdriver/BiDi/Modules/Script/CallFunctionCommand.cs
CallFunctionCommandclass and its parameters for callingfunctions.
ProxyConfiguration.cs
Define ProxyConfiguration class and derived typesdotnet/src/webdriver/BiDi/Modules/Session/ProxyConfiguration.cs
ProxyConfigurationclass and its derived types forconfiguring proxies.
ManualProxyConfigurationandPacProxyConfiguration.Subscription.cs
Introduce Subscription class for event managementdotnet/src/webdriver/BiDi/Subscription.cs
Subscriptionclass for managing event subscriptions.LogEntry.cs
Define LogEntry class and derived typesdotnet/src/webdriver/BiDi/Modules/Log/LogEntry.cs
LogEntryclass and its derived types for representing logentries.
ConsoleLogEntryandJavascriptLogEntry.ContinueResponseCommand.cs
Define ContinueResponseCommand and optionsdotnet/src/webdriver/BiDi/Modules/Network/ContinueResponseCommand.cs
ContinueResponseCommandclass and its parameters forcontinuing responses.
ProvideResponseCommand.cs
Define ProvideResponseCommand and optionsdotnet/src/webdriver/BiDi/Modules/Network/ProvideResponseCommand.cs
ProvideResponseCommandclass and its parameters forproviding responses.
ContinueRequestCommand.cs
Define ContinueRequestCommand and optionsdotnet/src/webdriver/BiDi/Modules/Network/ContinueRequestCommand.cs
ContinueRequestCommandclass and its parameters forcontinuing requests.
LogEntryConverter.cs
Implement LogEntryConverter for JSON serializationdotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/LogEntryConverter.cs
LogEntryConverterclass for JSON serialization ofLogEntrytypes.
LogEntryobjects.ContinueWithAuthCommand.cs
Define ContinueWithAuthCommand and optionsdotnet/src/webdriver/BiDi/Modules/Network/ContinueWithAuthCommand.cs
ContinueWithAuthCommandclass and its parameters forcontinuing with authentication.
settings.
EvaluateResultConverter.cs
Implement EvaluateResultConverter for JSON serializationdotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/EvaluateResultConverter.cs
EvaluateResultConverterclass for JSON serialization ofEvaluateResulttypes.EvaluateResultobjects.
SetCookieCommand.cs
Define SetCookieCommand and optionsdotnet/src/webdriver/BiDi/Modules/Storage/SetCookieCommand.cs
SetCookieCommandclass and its parameters for settingcookies.
MessageConverter.cs
Implement MessageConverter for JSON serializationdotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/MessageConverter.cs
MessageConverterclass for JSON serialization ofMessagetypes.
Messageobjects.LocateNodesCommand.cs
Define LocateNodesCommand and optionsdotnet/src/webdriver/BiDi/Modules/BrowsingContext/LocateNodesCommand.cs
LocateNodesCommandclass and its parameters for locatingnodes.
AddInterceptCommand.cs
Define AddInterceptCommand and optionsdotnet/src/webdriver/BiDi/Modules/Network/AddInterceptCommand.cs
AddInterceptCommandclass and its parameters for addingintercepts.
AddPreloadScriptCommand.cs
Define AddPreloadScriptCommand and optionsdotnet/src/webdriver/BiDi/Modules/Script/AddPreloadScriptCommand.cs
AddPreloadScriptCommandclass and its parameters foradding preload scripts.
WebDriver.Extensions.cs
Add WebDriver extension methods for BiDi protocoldotnet/src/webdriver/BiDi/WebDriver.Extensions.cs
IWebDriverto support BiDi protocol.BrowsingContext.
61 files
InternalIdConverter.cs
Add InternalIdConverter for JSON serialization.dotnet/src/webdriver/BiDi/Communication/Json/Converters/InternalIdConverter.cs
InternalIdConverterclass for JSON serialization.ReadandWritemethods forInternalId.ChannelConverter.cs
Add ChannelConverter for JSON serialization.dotnet/src/webdriver/BiDi/Communication/Json/Converters/ChannelConverter.cs
ChannelConverterclass for JSON serialization.ReadandWritemethods forChannel.HandleConverter.cs
Add HandleConverter for JSON serialization.dotnet/src/webdriver/BiDi/Communication/Json/Converters/HandleConverter.cs
HandleConverterclass for JSON serialization.ReadandWritemethods forHandle.RealmConverter.cs
Add RealmConverter for JSON serialization.dotnet/src/webdriver/BiDi/Communication/Json/Converters/RealmConverter.cs
RealmConverterclass for JSON serialization.ReadandWritemethods forRealm.RequestConverter.cs
Add RequestConverter for JSON serialization.dotnet/src/webdriver/BiDi/Communication/Json/Converters/RequestConverter.cs
RequestConverterclass for JSON serialization.ReadandWritemethods forRequest.GetRealmsCommand.cs
Add GetRealmsCommand and related records.dotnet/src/webdriver/BiDi/Modules/Script/GetRealmsCommand.cs
GetRealmsCommandclass and related records for commandparameters, options, and results.
GetTreeCommand.cs
Add GetTreeCommand and related records.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/GetTreeCommand.cs
GetTreeCommandclass and related records for command parameters,options, and results.
Message.cs
Add Message records for communication.dotnet/src/webdriver/BiDi/Communication/Message.cs
Messagerecord and derived records for success, error,and event messages.
SetViewportCommand.cs
Add SetViewportCommand and related records.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/SetViewportCommand.cs
SetViewportCommandclass and related records for commandparameters, options, and viewport structure.
LogModule.cs
Add LogModule for log entry subscriptions.dotnet/src/webdriver/BiDi/Modules/Log/LogModule.cs
LogModuleclass with methods for subscribing to log entryevents.
NavigateCommand.cs
Add NavigateCommand and related records.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/NavigateCommand.cs
NavigateCommandclass and related records for commandparameters, options, and results.
NewCommand.cs
Add NewCommand and related records.dotnet/src/webdriver/BiDi/Modules/Session/NewCommand.cs
NewCommandclass and related records for command parameters,options, and results.
PreloadScript.cs
Add PreloadScript class for managing preload scripts.dotnet/src/webdriver/BiDi/Modules/Script/PreloadScript.cs
PreloadScriptclass implementingIAsyncDisposablefor managingpreload scripts.
NavigationConverter.cs
Add NavigationConverter for JSON serialization.dotnet/src/webdriver/BiDi/Communication/Json/Converters/NavigationConverter.cs
NavigationConverterclass for JSON serialization.ReadandWritemethods forNavigation.HandleUserPromptCommand.cs
Add HandleUserPromptCommand and related records.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/HandleUserPromptCommand.cs
HandleUserPromptCommandclass and related records for commandparameters and options.
UserContext.cs
Add UserContext class for managing user contexts.dotnet/src/webdriver/BiDi/Modules/Browser/UserContext.cs
UserContextclass implementingIAsyncDisposablefor managinguser contexts.
ReloadCommand.cs
Add ReloadCommand and related records.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/ReloadCommand.cs
ReloadCommandclass and related records for command parametersand options.
ResponseData.cs
Add ResponseData record for network responses.dotnet/src/webdriver/BiDi/Modules/Network/ResponseData.cs
ResponseDatarecord for network response details.SetCookieHeader.cs
Add SetCookieHeader record for cookies.dotnet/src/webdriver/BiDi/Modules/Network/SetCookieHeader.cs
SetCookieHeaderrecord for setting cookie headers.SubscribeCommand.cs
Add SubscribeCommand and related records.dotnet/src/webdriver/BiDi/Modules/Session/SubscribeCommand.cs
SubscribeCommandclass and related records for commandparameters and options.
BrowsingContextInfo.cs
Add BrowsingContextInfo record for context info.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextInfo.cs
BrowsingContextInforecord for browsing context information.Initiator.cs
Add Initiator record and enum for network requests.dotnet/src/webdriver/BiDi/Modules/Network/Initiator.cs
Initiatorrecord andInitiatorTypeenum for network requestinitiators.
DeleteCookiesCommand.cs
Add DeleteCookiesCommand and related records.dotnet/src/webdriver/BiDi/Modules/Storage/DeleteCookiesCommand.cs
DeleteCookiesCommandclass and related records for commandparameters, options, and results.
BrowsingContextInputModule.cs
Add BrowsingContextInputModule for input actions.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextInputModule.cs
BrowsingContextInputModuleclass for performing input actions ina browsing context.
UserPromptOpenedEventArgs.cs
Add UserPromptOpenedEventArgs and UserPromptType enum.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/UserPromptOpenedEventArgs.cs
UserPromptOpenedEventArgsrecord for user prompt opened events.UserPromptTypeenum for different prompt types.BaseParametersEventArgs.cs
Add BaseParametersEventArgs for network events.dotnet/src/webdriver/BiDi/Modules/Network/BaseParametersEventArgs.cs
BaseParametersEventArgsabstract record for network eventarguments.
BytesValue.cs
Add BytesValue and derived records.dotnet/src/webdriver/BiDi/Modules/Network/BytesValue.cs
BytesValueabstract record and derived records for string andbase64 values.
Target.cs
Add Target and derived records.dotnet/src/webdriver/BiDi/Modules/Script/Target.cs
Targetabstract record and derived records for realm and contexttargets.
CapabilityRequest.cs
Add CapabilityRequest class for session capabilities.dotnet/src/webdriver/BiDi/Modules/Session/CapabilityRequest.cs
CapabilityRequestclass for session capability requests.ScriptEvaluateException.cs
Add ScriptEvaluateException class.dotnet/src/webdriver/BiDi/Modules/Script/ScriptEvaluateException.cs
ScriptEvaluateExceptionclass for handling script evaluationexceptions.
FetchTimingInfo.cs
Add FetchTimingInfo record for network timings.dotnet/src/webdriver/BiDi/Modules/Network/FetchTimingInfo.cs
FetchTimingInforecord for network fetch timing information.Cookie.cs
Add Cookie record and SameSite enum.dotnet/src/webdriver/BiDi/Modules/Network/Cookie.cs
Cookierecord for network cookies.SameSiteenum for cookie same-site policies.BeforeRequestSentEventArgs.cs
Add BeforeRequestSentEventArgs record.dotnet/src/webdriver/BiDi/Modules/Network/BeforeRequestSentEventArgs.cs
BeforeRequestSentEventArgsrecord for before request sentevents.
ITransport.cs
Add ITransport interface for communication.dotnet/src/webdriver/BiDi/Communication/Transport/ITransport.cs
ITransportinterface for communication transport.ResponseCompletedEventArgs.cs
Add ResponseCompletedEventArgs record.dotnet/src/webdriver/BiDi/Modules/Network/ResponseCompletedEventArgs.cs
ResponseCompletedEventArgsrecord for response completed events.SerializationOptions.cs
Add SerializationOptions class and ShadowTree enum.dotnet/src/webdriver/BiDi/Modules/Script/SerializationOptions.cs
SerializationOptionsclass andShadowTreeenum for serializationoptions.
FetchErrorEventArgs.cs
Add FetchErrorEventArgs record.dotnet/src/webdriver/BiDi/Modules/Network/FetchErrorEventArgs.cs
FetchErrorEventArgsrecord for fetch error events.ResponseStartedEventArgs.cs
Add ResponseStartedEventArgs record.dotnet/src/webdriver/BiDi/Modules/Network/ResponseStartedEventArgs.cs
ResponseStartedEventArgsrecord for response started events.TraverseHistoryCommand.cs
Add TraverseHistoryCommand and related records.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/TraverseHistoryCommand.cs
TraverseHistoryCommandclass and related records for commandparameters, options, and results.
AuthCredentials.cs
Add AuthCredentials and derived records.dotnet/src/webdriver/BiDi/Modules/Network/AuthCredentials.cs
AuthCredentialsabstract record and derived record for basicauthentication.
EventArgs.cs
Add EventArgs and derived records.dotnet/src/webdriver/BiDi/EventArgs.cs
EventArgsabstract record and derived record for browsingcontext events.
RemovePreloadScriptCommand.cs
Add RemovePreloadScriptCommand and related records.dotnet/src/webdriver/BiDi/Modules/Script/RemovePreloadScriptCommand.cs
RemovePreloadScriptCommandclass and related records for commandparameters and options.
RemoveUserContextCommand.cs
Add RemoveUserContextCommand and related records.dotnet/src/webdriver/BiDi/Modules/Browser/RemoveUserContextCommand.cs
RemoveUserContextCommandclass and related records for commandparameters and options.
AuthRequiredEventArgs.cs
Add AuthRequiredEventArgs record.dotnet/src/webdriver/BiDi/Modules/Network/AuthRequiredEventArgs.cs
AuthRequiredEventArgsrecord for authentication required events.RemoveInterceptCommand.cs
Add RemoveInterceptCommand and related records.dotnet/src/webdriver/BiDi/Modules/Network/RemoveInterceptCommand.cs
RemoveInterceptCommandclass and related records for commandparameters and options.
DisownCommand.cs
Add DisownCommand and related records.dotnet/src/webdriver/BiDi/Modules/Script/DisownCommand.cs
DisownCommandclass and related records for command parameters.GetUserContextsCommand.cs
Add GetUserContextsCommand and related records.dotnet/src/webdriver/BiDi/Modules/Browser/GetUserContextsCommand.cs
GetUserContextsCommandclass and related records for commandoptions and results.
ChannelValue.cs
Add ChannelValue and ChannelProperties records.dotnet/src/webdriver/BiDi/Modules/Script/ChannelValue.cs
ChannelValuerecord andChannelPropertiesrecord for channelvalues.
RemoteReference.cs
Add RemoteReference and derived records.dotnet/src/webdriver/BiDi/Modules/Script/RemoteReference.cs
RemoteReferenceabstract record and derived records for sharedand remote object references.
UserPromptClosedEventArgs.cs
Add UserPromptClosedEventArgs record.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/UserPromptClosedEventArgs.cs
UserPromptClosedEventArgsrecord for user prompt closed events.ReleaseActionsCommand.cs
Add ReleaseActionsCommand and related records.dotnet/src/webdriver/BiDi/Modules/Input/ReleaseActionsCommand.cs
ReleaseActionsCommandclass and related records for commandparameters and options.
FailRequestCommand.cs
Add FailRequestCommand and related records.dotnet/src/webdriver/BiDi/Modules/Network/FailRequestCommand.cs
FailRequestCommandclass and related records for commandparameters and options.
ActivateCommand.cs
Add ActivateCommand and related records.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/ActivateCommand.cs
ActivateCommandclass and related records for command parametersand options.
CloseCommand.cs
Add CloseCommand and related records.dotnet/src/webdriver/BiDi/Modules/BrowsingContext/CloseCommand.cs
CloseCommandclass and related records for command parametersand options.
InternalId.cs
Add InternalId class.dotnet/src/webdriver/BiDi/Modules/Script/InternalId.cs
InternalIdclass for internal identifiers.Handle.cs
Add Handle class.dotnet/src/webdriver/BiDi/Modules/Script/Handle.cs
Handleclass for script handles.Realm.cs
Add Realm class.dotnet/src/webdriver/BiDi/Modules/Script/Realm.cs
Realmclass for script realms.Channel.cs
Add Channel class.dotnet/src/webdriver/BiDi/Modules/Script/Channel.cs
Channelclass for script channels.RequestData.cs
Add RequestData record for network requests.dotnet/src/webdriver/BiDi/Modules/Network/RequestData.cs
RequestDatarecord for network request details.CapabilitiesRequest.cs
Add CapabilitiesRequest class.dotnet/src/webdriver/BiDi/Modules/Session/CapabilitiesRequest.cs
CapabilitiesRequestclass for session capabilities requests.StatusCommand.cs
Add StatusCommand and related records.dotnet/src/webdriver/BiDi/Modules/Session/StatusCommand.cs
StatusCommandclass and related records for command options andresults.