-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rust] Include arguments for skipping drivers and browsers in path #14444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
CI Failure Feedback 🧐(Checks updated until commit e289487)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
diemol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bonigarcia!
…eleniumHQ#14444) * [rust] Include arguments for skipping drivers and browsers in path * [rust] Update skip logic with the current codebase --------- Co-authored-by: Diego Molina <[email protected]>
User description
Description
This PR implements a couple of new arguments in Selenium Manager:
--skip_driver_in_path: For not using the drivers found in the PATH.--skip_browser_in_path: For not using the browsers found in the PATH.As usual, these arguments can be enabled using the config file or environment variables (e.g.,
SE_SKIP_DRIVER_IN_PATH=true).The following executions showcase its use:
Usual execution with (incompatible) driver in path:
Same execution with (incompatible) driver in the path but using
--skip_driver_in_path:Motivation and Context
It implements #12985. It reuses the code from #12960.
Types of changes
Checklist
PR Type
enhancement
Description
--skip_driver_in_pathand--skip_browser_in_pathto allow users to skip using drivers and browsers found in the PATH.ManagerConfigto include new boolean fields for skipping drivers and browsers in the PATH.Changes walkthrough 📝
config.rs
Add skip driver and browser in path options to ManagerConfigrust/src/config.rs
skip_driver_in_pathandskip_browser_in_pathboolean fields toManagerConfig.ManagerConfigimplementation to include new fields.lib.rs
Implement logic to skip drivers and browsers in PATHrust/src/lib.rs
browsers.
main.rs
Add CLI options to skip drivers and browsers in PATHrust/src/main.rs
skip_driver_in_pathandskip_browser_in_path.