[feature] add method RemoteWebDriver.isDownloadsEnabled()

[asolntsev]

User description

💥 What does this PR do?

I want to add method RemoteWebDriver.isDownloadsEnabled() which re

🔧 Motivation

I need to check if current webdriver has capability se:downloadsEnabled.

My scenario looks like this:

  public File downloadFile(HasDownloads webdriver) {
    if (webdriver.isDownloadsEnabled()) {
      return webdriver.getDownloadableFiles().get(0);
    }
    else {
        // click element, look into "Downloads" folder etc.
    }
  }

🔄 Types of changes

• New feature
• Breaking change
  • any 3-rd party webdrivers that implement HasDownloads, but don't extend RemoteWebDriver, will need to implement method isDownloadsEnabled().

---

PR Type

Enhancement

---

Description

• Add isDownloadsEnabled() method to RemoteWebDriver

• Require HasDownloads implementors to define isDownloadsEnabled()

• Refactor download capability check in HasDownloads

---

Changes walkthrough 📝

Relevant files

Enhancement

HasDownloads.java Add and refactor downloads-enabled capability checks in HasDownloads java/src/org/openqa/selenium/HasDownloads.java Add abstract isDownloadsEnabled() method to interface Add static utility for capability check Refactor requireDownloadsEnabled to use new method Update documentation for new method +11/-2    RemoteWebDriver.java Implement isDownloadsEnabled() in RemoteWebDriver                java/src/org/openqa/selenium/remote/RemoteWebDriver.java Implement isDownloadsEnabled() using HasDownloads utility +4/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Interface Compatibility The PR adds a new abstract method to the HasDownloads interface without a default implementation, which will break existing implementations that don't extend RemoteWebDriver. Consider providing a default implementation that uses the static utility method. boolean isDownloadsEnabled();

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Add missing annotation Add the @OverRide annotation to the isDownloadsEnabled() method since it implements a method from the HasDownloads interface. This improves code clarity and allows the compiler to verify correct implementation. java/src/org/openqa/selenium/remote/RemoteWebDriver.java [652-654] +@Override public boolean isDownloadsEnabled() { return HasDownloads.isDownloadsEnabled(capabilities); } Apply / Chat Suggestion importance[1-10]: 4 __ Why: The suggestion correctly identifies that the @Override annotation should be added since isDownloadsEnabled() implements an interface method from HasDownloads. This is a minor but valid code style improvement.	Low
Update

[asolntsev]

Add the @OverRide annotation to the isDownloadsEnabled()

Thanks, fixed.

[nvborisenko]

That's something strange. Today isDownloadsEnabled(), tomorrow isUploadEnabled(). Who enables it? I want to believe it should be determined by the initiator. And core question who is "initiator".

[asolntsev]

That's something strange. Today isDownloadsEnabled(), tomorrow isUploadEnabled(). Who enables it? I want to believe it should be determined by the initiator. And core question who is "initiator".

I absolutely agree with you: in a typical "test automation" project, the initiator knows.
But my case is different: I want to check it in a generic testing library.

I am implementing "file download" method. I receive the webdriver from end-user, and I need to check if the downloads are enabled.