Add 'indent' parameter to 'put' command #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the contribution @cavus700. Before merging I'd like to add support for the indent flag across all commands for consistency, along with the related tests. You're welcome to do this, but if not I expect I'll get to it in the next couple of days. |
Owner
|
I've added the option across the commands but would like to add some tests next. |
Contributor
Author
|
Thank you for extending the PR :) Sure this feature is not time critical for me but I thought it would be a nice extension. Do you need some help with the tests? |
Owner
|
I'll take all the help I can get. I'm juggling a lot at the moment |
Owner
|
Thanks for adding those tests @cavus700 that's great. Lets get this merged! Thanks for the contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add a new command line parameter for the put-command to set the indention level for various outputs. The different parsers are already respecting the
IndentOptionbut it is not possible to pass it via the cli.