Change 'incompletely specified behavior' phrasing to 'limited local nondeterminism' #141
Conversation
Nondeterminism.md
Outdated
There was a problem hiding this comment.
apologies for an unimportant question, but was the space before : intentional here? (it would feel natural for me to not have it there, but maybe it's a style I'm not familiar with)
There was a problem hiding this comment.
You're right, it'd look better w/o space before.
Nondeterminism.md
Outdated
There was a problem hiding this comment.
Another probably unimportant note, it might be better to avoid saying "fully deterministic" because in a more general sense, there is or will be nondeterminism in wasm - stuff like calling a random number generator. Very nitpicky of course, as your intention is clear, so feel free to ignore.
There was a problem hiding this comment.
Haha, good point, I forgot about random. I can reword.
|
lgtm |
Nondeterminism.md
Outdated
There was a problem hiding this comment.
Drop "near-"? We want native performance!
There was a problem hiding this comment.
I think "near-" is an acknowledgement that we are sandboxed and that we are providing a portability abstraction that discards certain unappetizing-but-nonetheless-expedient implementation details, and until we get hardware support there's always going to be some overhead. But ultimately it's a question of taste here.
There was a problem hiding this comment.
Yeah, this is just the conservative "don't overpromise" engineer in me, but "native" is probably fine here, so I'll take out "near-".
Nondeterminism.md
Outdated
|
lgtm after nit, and assuming you move the race/data stuff to another PR. |
|
Pulling this now-hidden note into the main discussion: So as @jfbastien pointed out, there are two levels of non-determinism here:
and 2 isn't really called out, so I think a further update is necessary. |
|
How about this? |
|
lgtm |
|
@sunfishcode too? |
Nondeterminism.md
Outdated
There was a problem hiding this comment.
I don't know if this is too pedantic, but it's also visible between API calls and WebAssembly program termination.
There was a problem hiding this comment.
True true, we must never forget termination.
…ename-incompletely-specified-behavior
…on nondeterminism of load
|
How about this? I couldn't think of how non-termination was visible except through APIs (like |
|
lgtm |
…d-behavior Change 'incompletely specified behavior' phrasing to 'limited local nondeterminism'
As discussed in #107.