Try out the new WordPress/action-wp-playground-pr-preview GitHub Action
#144
Conversation
…ify the name and path of the uploaded zip
…ayground-pr-preview action
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| on: | ||
| workflow_run: | ||
| workflows: ["Build Plugin Zip"] | ||
| types: | ||
| - completed |
There was a problem hiding this comment.
For some reason this doesn't seem to get triggered, at least in this PR.
There was a problem hiding this comment.
@jeffpaul @dkotter This is probably the crux:
This event will only trigger a workflow run if the workflow file exists on the default branch.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run
There was a problem hiding this comment.
Ah, thanks for that. I think then the only way to fully test this will be to merge it in and 🤞🏻
There was a problem hiding this comment.
merged, now crossing fingers...
There was a problem hiding this comment.
Workflow is failing with a permission error. Opened #150 to try and fix that but still gives the same error 😢
github-project-automation
bot
moved this from In progress
to Done
in WordPress AI Planning & Roadmap
What?
Update our Build Plugin Zip and Pull Request Comments workflows to use the new
WordPress/action-wp-playground-pr-previewAction.Why?
We've had a few issues with our current setup (see #65 for latest work there) and we've been asked to try using the
WordPress/action-wp-playground-pr-previewAction to see if that makes things work.How?
Follows the instructions in the
WordPress/action-wp-playground-pr-previewrepo: https://github.com/WordPress/action-wp-playground-pr-preview/?tab=readme-ov-file#advanced-testing-built-ci-artifactsBuild Plugin Zipworkflow fire when a PR is openedPull Request Commentsworkflow to fire after theBuild Plugin Zipworkflow has finishedWordPress/action-wp-playground-pr-previewActionTesting Instructions
Ensure a Playground test link gets added to this PR description and it works as expected