-
Notifications
You must be signed in to change notification settings - Fork 139
Correct the fallback image in PICTURE element #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks @westonruter for the feedback. PR ready for review. |
westonruter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm missing something (like the issues I just commented on being addressed elsewhere) this doesn't seem quite there.
westonruter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like $this->mock_frontend_body_hooks() needs to be added to the remaining test cases as well. Alternatively, it could be added to set_up instead.
|
@westonruter @adamsilverstein PR updated and ready for review. |
Co-authored-by: Weston Ruter <[email protected]>
|
@adamsilverstein @joemcgill Could you please review this when you have a moment? Thanks! |
joemcgill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good.
adamsilverstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
|
Worked well in my testing, thanks for working on this @mukeshpanchal27 🎉 |
Summary
This PR accounts following:
image/jpegas fallback image for Picture element.image/jpegmime from Picture > Source and return only additional mime.WP_HTML_Tag_Processorso it check the additionalnext_tagin while loop.