Skip to content

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jul 29, 2024

Summary

This PR accounts following:

  • Return image/jpeg as fallback image for Picture element.
  • Remove image/jpeg mime from Picture > Source and return only additional mime.
  • Use share fixture for tests.
  • Add/update unit test that reflect the changes.
  • Reinitialize the WP_HTML_Tag_Processor so it check the additional next_tag in while loop.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Jul 29, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Jul 29, 2024
@mukeshpanchal27 mukeshpanchal27 added the skip changelog PRs that should not be mentioned in changelogs label Jul 29, 2024
@mukeshpanchal27 mukeshpanchal27 added this to the webp-uploads n.e.x.t milestone Jul 29, 2024
@mukeshpanchal27 mukeshpanchal27 added no milestone PRs that do not have a defined milestone for release and removed no milestone PRs that do not have a defined milestone for release labels Jul 29, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review July 29, 2024 09:40
@github-actions
Copy link

github-actions bot commented Jul 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: joemcgill <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27
Copy link
Member Author

Thanks @westonruter for the feedback. PR ready for review.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something (like the issues I just commented on being addressed elsewhere) this doesn't seem quite there.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like $this->mock_frontend_body_hooks() needs to be added to the remaining test cases as well. Alternatively, it could be added to set_up instead.

@adamsilverstein adamsilverstein self-requested a review August 7, 2024 22:09
@mukeshpanchal27
Copy link
Member Author

@westonruter @adamsilverstein PR updated and ready for review.

Co-authored-by: Weston Ruter <[email protected]>
@mukeshpanchal27
Copy link
Member Author

@adamsilverstein @joemcgill Could you please review this when you have a moment? Thanks!

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good.

@adamsilverstein adamsilverstein self-requested a review August 8, 2024 20:25
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@adamsilverstein
Copy link
Member

Worked well in my testing, thanks for working on this @mukeshpanchal27 🎉

@mukeshpanchal27 mukeshpanchal27 merged commit 56b653f into trunk Aug 9, 2024
@mukeshpanchal27 mukeshpanchal27 deleted the fix/1316-check-img-src branch August 9, 2024 04:06
@westonruter westonruter changed the title Picture element: Correct the fallback image Correct the fallback image in PICTURE element Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken

Projects

Status: Done 😃

Development

Successfully merging this pull request may close these issues.

5 participants