Convert WebP to AVIF on upload #1724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshpanchal27
added
[Type] Enhancement
mukeshpanchal27
requested review from
adamsilverstein,
felixarntz and
westonruter
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
adamsilverstein
left a comment
adamsilverstein
left a comment
There was a problem hiding this comment.
Looks good, nice work! I had one point about the use of $mime_type as a variable
adamsilverstein
approved these changes
Dec 12, 2024
Member
|
Nice work @mukeshpanchal27! |
Member
Author
|
@westonruter or @felixarntz Could one of you please review this so we can merge it? Thanks! 🙏 |
westonruter
approved these changes
Dec 13, 2024
Member
|
🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1557
Relevant technical choices
Settings > Media > Modern Image Formats > Image output format (Select "AVIF")WebPImage.