fix: use environment variable for PIP_ROOT_USER_ACTION
#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the fix from actions#259 since every platform for 3.8.10 / 3.9.13 has been rebuilt instead of just macOS arm64 being added. The regression was introduced in actions#223
cognifloyd
approved these changes
Apr 26, 2024
aparnajyothi-y
approved these changes
Apr 29, 2024
priyagupta108
approved these changes
Apr 29, 2024
priya-kinthali
approved these changes
Apr 29, 2024
HarithaVattikuti
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the fix from #259 since every platform for 3.8.10 / 3.9.13 has been rebuilt instead of just macOS arm64 being added.
This also fixes the build workflow to error out on installation failure which should have prevented the broken build to be published:
Since the Windows version was not erroring out properly, I also added a check for pip installation / update failure:
Now that everything errors out properly, we can check that the fix works in https://github.com/mayeut/python-versions/actions/runs/8853283598
Towards fixing actions/setup-python#853