Skip to content

Add and configure ESLint and update configuration for Prettier #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IvanZosimov merged 5 commits into from
Mar 9, 2023
Merged

Add and configure ESLint and update configuration for Prettier #617

IvanZosimov merged 5 commits into from
Mar 9, 2023

Conversation

@IvanZosimov
Copy link
Contributor

@IvanZosimov IvanZosimov commented Mar 3, 2023

Description:
In the scope of this PR, we are adding the ESLint tool and updating Prettier:

  • ESLint dependencies were added;
  • Configuration files .eslintrc.js and .eslintignore were added;
  • Prettier dependency was updated;
  • Configuration files .prettiertrc.js and .prettierignore were added, .prettierrc.json was removed;
  • Commands in the package.json file were updated;
  • Repository was formatted and linted according to the added configuration files;
  • Unit-tests were updated;
  • File .gitattributes was updated to force git to replace CRLF eof to LF eof;

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@IvanZosimov IvanZosimov requested a review from a team as a code owner March 3, 2023 13:32
@IvanZosimov IvanZosimov merged commit ec365b4 into actions:main Mar 9, 2023
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
@IvanZosimov
Add and configure ESLint and update configuration for Prettier (actio…
fec4cd4 
…ns#617)

* Add ESLint, update Prettier

* Update docs

* Update tests

* Update licenses

* Fix review points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes

@MaksimZhukov MaksimZhukov MaksimZhukov approved these changes

@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes

@panticmilos panticmilos panticmilos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IvanZosimov @dmitry-shibanov @MaksimZhukov @marko-zivic-93 @panticmilos