Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Conversation

@shiraji
Copy link
Contributor

@shiraji shiraji commented Oct 12, 2015

see #1591

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test sufficient? You should check actually the code is in order, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You are right. I fixed the test case.

@shiraji
Copy link
Contributor Author

shiraji commented Oct 13, 2015

mmm...I couldn't reproduce this failure. I ran following commands:

mvn clean
mvn install -Dandroid.sdk.path=/opt/android-sdk/

Could you point how I can fix this problem, @WonderCsabo ?

@shiraji
Copy link
Contributor Author

shiraji commented Oct 13, 2015

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        MenuInflater menuInflater = getMenuInflater();
        this.menu = menu.findItem(R.id.menu);
        this.menu1 = menu.findItem(R.id.menu1);
        this.menu2 = menu.findItem(R.id.menu2);
        this.menu3 = menu.findItem(R.id.menu3);
        return super.onCreateOptionsMenu(menu);
    }

There is R.id...mmm, let me create another test cases.

@WonderCsabo
Copy link
Member

WonderCsabo commented Oct 13, 2015 via email

@shiraji
Copy link
Contributor Author

shiraji commented Oct 17, 2015

@WonderCsabo Could you give me a sample unit test code? After I learn phax/jcodemodel, I still don't understand how I implement this unit test code. Thanks.

@WonderCsabo
Copy link
Member

@shiraji i just rebased your branch to latest develop use the latest modifications for jcodemodel, and fixed the test case. Check out this branch.

@WonderCsabo
Copy link
Member

BTW @shiraji you do not need to log the generated Java code. You can just check the file under target/generated-test.

@shiraji
Copy link
Contributor Author

shiraji commented Oct 18, 2015

Thanks, let me fix the issue.

I logged the generated Java code just because I want to know what is the difference between my local generated code and travic ci's generated code.

@WonderCsabo
Copy link
Member

Please squash the last commit into commit before.

@shiraji
Copy link
Contributor Author

shiraji commented Oct 18, 2015

Here you go.

WonderCsabo added a commit that referenced this pull request Oct 28, 2015
Fixed a problem with traversing ancestors
@WonderCsabo WonderCsabo merged commit 09fe7e3 into androidannotations:develop Oct 28, 2015
@WonderCsabo WonderCsabo added this to the 4.0 milestone Oct 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants