-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fixed a problem with travasing ancestors. #1592
Fixed a problem with travasing ancestors. #1592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test sufficient? You should check actually the code is in order, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. You are right. I fixed the test case.
|
mmm...I couldn't reproduce this failure. I ran following commands: mvn clean
mvn install -Dandroid.sdk.path=/opt/android-sdk/Could you point how I can fix this problem, @WonderCsabo ? |
@Override
public boolean onCreateOptionsMenu(Menu menu) {
MenuInflater menuInflater = getMenuInflater();
this.menu = menu.findItem(R.id.menu);
this.menu1 = menu.findItem(R.id.menu1);
this.menu2 = menu.findItem(R.id.menu2);
this.menu3 = menu.findItem(R.id.menu3);
return super.onCreateOptionsMenu(menu);
}There is |
|
We are using a better way to generate imports to R classes, so we no longer
import the inner R classes, but only R. This is the recommended on Android.
See #1548
|
|
@WonderCsabo Could you give me a sample unit test code? After I learn phax/jcodemodel, I still don't understand how I implement this unit test code. Thanks. |
|
BTW @shiraji you do not need to log the generated Java code. You can just check the file under target/generated-test. |
|
Thanks, let me fix the issue. I logged the generated Java code just because I want to know what is the difference between my local generated code and travic ci's generated code. |
|
Please squash the last commit into commit before. |
|
Here you go. |
Fixed a problem with traversing ancestors
see #1591