Skip to content

Conversation

@lejard-h
Copy link
Collaborator

@lejard-h lejard-h commented Oct 23, 2021

Run dart migrate everywhere without accepting changes. So we have // @dart=2.9 header on every file and all pubspec.yaml opt in to null safety

Also use observable package from github rep (see #34)

Fix #41

@lejard-h
Copy link
Collaborator Author

@GZGavinZhao Can we have a null-safety branch to merge this and keep master branch without null safety.

Or do you want to keep dev branch (I am not sure if it's building right now)

@GZGavinZhao
Copy link

Yes, null-safety sounds good to me. I think for now it's better to leave dev clean as I'm not sure what @dukefirehawk is up to.

@GZGavinZhao
Copy link

@lejard-h Done. You can create a PR to that branch now. I will fix the workflow error on master and merge the change to null-safety later.

@lejard-h lejard-h changed the base branch from master to null-safety October 26, 2021 13:30
@lejard-h lejard-h changed the title Dart migrate Run dart migrate Oct 26, 2021
@lejard-h lejard-h marked this pull request as ready for review October 27, 2021 12:35
@GZGavinZhao GZGavinZhao merged commit 255ace7 into angulardart-community:null-safety Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run dart migrate on all source without accepting modification, so it generate // @dart = 2.9 comments everywhere

2 participants