Skip to content

Conversation

@jodinathan
Copy link
Collaborator

Fixed all files.
Exception from the material_input_multiline.dart at:

// TODO(google): remove after the bug is fixed.
          ..detectChanges();

As I don't know what bug it is talking about.

@jodinathan
Copy link
Collaborator Author

fixes #12

@GZGavinZhao
Copy link

GZGavinZhao commented Oct 27, 2021

@jodinathan I'm not sure if you can see the details of the workflow run, but if you can, please fix the little formatting. You can simply run dart format . in the top level directory and it will format everything for you. Thanks!

@GZGavinZhao
Copy link

So far this looks good:

grinder running analyze

analyze
  Counting number of Dart files...
  Analyzing...
  100% Done!
  1 out of 298 files are still using deprecated API!
- [ ] material_input/material_input_multiline.dart

finished in 6.8 seconds

Just waiting for the CI to run one more time to make sure nothing breaks during the build.

@jodinathan
Copy link
Collaborator Author

fixed #24

@jodinathan jodinathan mentioned this pull request Oct 27, 2021
54 tasks
@GZGavinZhao GZGavinZhao linked an issue Oct 27, 2021 that may be closed by this pull request
3 tasks
@GZGavinZhao GZGavinZhao merged commit 309de8f into angulardart-community:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warnings: doesn't use "ChangeDetectionStrategy.OnPush"

2 participants