add cpu percentage and value

[DaanHoogland]

cpu percentage and value as for memory #4478

ISSUE TYPE

• Improvement Request

COMPONENT NAME

API, metrics

CLOUDSTACK VERSION

all

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

as in #4478 (for memory), cpu could have percentage and value output for use in UI or scripts

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

[davidjumani]

@DaanHoogland Would this mean reverting cpuallocated to the original allocated value and adding a new field cpuallocatedwithoverprovisioning ?

[DaanHoogland]

no, it would mean adding two new response parameters as done for memory and leaving the existing as is but deprecated. cc @weizhouapache @rhtyd

[davidjumani]

@DaanHoogland It's always been a percentage, just that it was changed to consider overprovisioning in 09de5e0 So would it make sense to revert it and add a new field cpuallocatediwthoverprovisioning for naming consistency ?

[DaanHoogland]

so what would the resulting field(-names) be, @davidjumani ?
and which ones will in the endd be deprecated?

[davidjumani]

I'd suggest reverting cpuallocated to not consider overcommit and introducing cpuallocatediwthoverprovisioning to follow the naming convention here
https://github.com/apache/cloudstack/blob/4.14/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java#L106
https://github.com/apache/cloudstack/blob/4.14/api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java#L115

[rohityadavcloud]

Fixed in #4499