-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As part of this fix, added a new property called "isDisabled" for a field in a dialog. If this function returns true, then the field will be disabled. |
|
@rashmidixit change the PR's base branch to 4.9 please. |
|
@rhtyd This is a minor improvement and hence in master. I have updated the corresponding bugs' fix version. |
|
@rashmidixit Code LGTM. Please provide screenshots of the changes. |
|
why not change vmActionfilter in ui/scripts/instances.js ? |
|
@ustcweizhou The reason for not putting this in vmActionFilter is that the snapshot action itself is allowed when a VM is shut down. We only want to disable the option for memory snapshot which is not valid in this case. Hope this clarifies. |
|
ping @koushik-das. When VM is running and snapshot option is clicked, the memory option is enabled. When VM is stopped and snapshot option is clicked, the memory option is disabled. |
|
Test results are as desired. LGTM |
|
tag:mergeready |
|
LGTM (based on code review) |
Refer to CLOUDSTACK-9695 for more details.