Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrche… #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by condition stated in line 3014
|
cloudstack-pull-requests #429 SUCCESS |
kishankavala
pushed a commit
to kishankavala/cloudstack
that referenced
this pull request
Jun 25, 2015
…strator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by condition stated in line 3014 Signed-off-by: Rohit Yadav <[email protected]> This closes apache#449
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
Fixes #449 Signed-off-by: Rohit Yadav <[email protected]>
weizhouapache
pushed a commit
to weizhouapache/cloudstack
that referenced
this pull request
May 30, 2024
This adds a NPE check on the s_depot.global() which can cause NPE in case of unit tests, where s_depot is not null but the underlying config dao is null (not mocked or initialised) via `s_depot.global()` becomes null. Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…strator.java
If answer is null, method will throw ConnectionException in line 3016 as satisfied by condition stated in line 3014