CLOUDSTACK-8556: Unable to delete attached volume in cleanup #481
Conversation
|
cloudstack-pull-requests #487 FAILURE |
There was a problem hiding this comment.
Why reboot and then delete? Also add suitable description and test run log results to the description.
pritisarap12
force-pushed
the
deleteVolume
branch
2 times, most recently
from
e291f8c to
ae17385
Compare
pritisarap12
force-pushed
the
deleteVolume
branch
from
ae17385 to
5bac197
Compare
|
Removed reboot as it is not needed. Storage and Snapshot Limit ... === TestName: test_01_storage_snapshots_limits | Status : SUCCESS === Ran 1 test in 300.585s OK |
|
Can you please explain why the test case was failing before? Why the cleanup was failing for volume? |
|
cloudstack-pull-requests #502 FAILURE |
|
cloudstack-pull-requests #501 SUCCESS |
|
cloudstack-pull-requests #504 FAILURE |
|
cloudstack-pull-requests #503 SUCCESS |
|
Delete volume was failing in cleanup before because volume was not in detached state as snapshot creation failed and detach volume command did not get executed so volume remains in attached state. |
|
cloudstack-pull-requests #647 SUCCESS |
There was a problem hiding this comment.
cleanup has to be declared before skipping the test case
There was a problem hiding this comment.
Updated testpath as per the review comment.
|
cloudstack-pull-requests #662 SUCCESS |
|
The description of the pull request isn't really specific. Looking at the files changed it is only a test case which changed, right? No CS code itself. |
|
Sanjeev N on [email protected] replies: |
|
In that case LGTM Next time try to be more descriptive, since the Jira issue didn't show it either. I really didn't know what you meant. |
|
LGTM, squashing and merging; please squash your changes in future as you iterate on your PR |
Signed-off-by: Rohit Yadav <[email protected]> This closes apache#481
Signed-off-by: Rohit Yadav <[email protected]>
* Commit for PR shapeblue/cloudstack-apple#471 This PR adds a flag (customType) to HypervisorType to differentiate if a hypervisor plugin is built-in or customized. With the customType flag, we can isolate conditional checks for allow the customized hypervisor plugin to proceed. * Add customType field to HypervisorType to differentiate if the plugin is a customized type * Address @shwstppr's comments * Define a enum in HypervisorType to indicate specific functionalities of a hypervisor plugin type * Refactoring to define if the hypervisor supports the operation during initialization of the HypervisorType. * Remove ROOT_DISK_SIZE_OVERRIDE_SUPPORTING_HYPERVISORS --------- Co-authored-by: Annie Li <[email protected]>
5 participants
No description provided.