findbugs UC useless condition #490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure what findbugs means yet, but this should at least turn both warnings into one.
Member
There was a problem hiding this comment.
is this assert necessary ;)
Contributor
Author
There was a problem hiding this comment.
it was done like this in two places by Alena. I had the idea she had a goal in mind. the assert is only nice in debug situation so her goal was probably educating developers. the following if negates it, kind of completely.
@bhaisaab it is also a test of the new findbugs messages that i am leaving it in for. Shall we?
|
cloudstack-pull-requests #505 FAILURE |
kishankavala
pushed a commit
to kishankavala/cloudstack
that referenced
this pull request
Jun 25, 2015
…his should at least turn both warnings into one. Signed-off-by: Daan Hoogland <[email protected]> This closes apache#490
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
Fixes #490 Fixes #491 Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure what findbugs means yet, is it negating the if-condition against the assert?
This should at least turn both warnings into one.