CLOUDSTACK-8578: implement state=present for listing only non-destroyed VMs #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cloudstack-pull-requests #633 SUCCESS |
Contributor
There was a problem hiding this comment.
Not sure if this make sense but is Expunged not !Present as well?
Member
Author
There was a problem hiding this comment.
Good catch, IMHO Expunged is not necessary but Expunging like we use for user e.g. https://github.com/resmo/cloudstack/blob/fix/CLOUDSTACK-8578-extend/server/src/com/cloud/api/query/QueryManagerImpl.java#L984
…ed VMs So the behavior before this fix can be used in a proper way.
resmo
changed the title
|
cloudstack-pull-requests #641 SUCCESS |
kishankavala
pushed a commit
to kishankavala/cloudstack
that referenced
this pull request
Jun 25, 2015
…ed VMs So the behavior before this fix can be used in a proper way. Signed-off-by: Daan Hoogland <[email protected]> This closes apache#513
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
Fixes #512 Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see #510 (comment)
RFC @bhaisaab