Skip to content

Conversation

@likitha
Copy link

@likitha likitha commented Jul 1, 2015

…a for volume.

Update chain info of a volume after migration.

…a for volume.

Update chain info of a volume after  migration.
@asfbot
Copy link

asfbot commented Jul 1, 2015

cloudstack-pull-requests #681 SUCCESS
This pull request looks good

@sateesh-chodapuneedi
Copy link
Member

LGTM.
Good to see this patch updating chain information for all 3 cases of storage migration,

  1. volume migration
  2. vm migration with storage within cluster
  3. vm migration across storage within cluster

@sureshanaparti
Copy link
Contributor

Code changes to update the volume chain info are perfect.

@DaanHoogland
Copy link
Contributor

code changes good or not, let's not accept any changes without (unit) tests any more.

@remibergsma
Copy link
Contributor

Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-).

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#508
This closes apache#384
This closes apache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372
@rohityadavcloud
Copy link
Member

LGTM

@asfgit asfgit closed this in f499281 Aug 26, 2015
rohityadavcloud pushed a commit that referenced this pull request Jan 20, 2021
…age creation Forms (#548)

Add storage policies field for DiskOffering, COmputeOffering and Primary storage creation Forms

Co-authored-by: Pearl Dsilva <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants