Persistence of VM stats #5984

joseflauzino · 2022-02-10T21:13:05Z

Description

This PR addresses issue #5935.

In summary, this PR makes ACS persist VM stats in the database to provide more consistency and make it possible to obtain historical data.

For more information, please refer to the spec contained in issue #5935.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots

New API

Getting all available stats:
Filtering by start and end date:

UI changes

Metrics disabled. It shows all VMs:
Metrics enabled. It shows only running VMs and their current stats:
Metrics enabled and filtering by stopped VMs. It forces the display of stopped VMs and their latest stats collected (not reflecting their current stats):

How Has This Been Tested?

I added unit tests to several methods.

Also, in a local lab, I performed the following tests:

I tested different combinations of the global settings vm.stats.increment.metrics, vm.stats.max.retention.time, and vm.stats.interval. All tests resulted in the expected behavior, as described in section 2.2 of the spec.
I tested the listVirtualMachinesMetrics API with different combinations of its new accumulate parameter with the global configuration vm.stats.increment.metrics, and everything worked as expected. See sections 2.2 and 3.3 of the spec for more details.
I tested the UI modifications mentioned in section 3.4 of the spec. The obtained behavior was as follows:
- When clicking on the "Metrics" button only running VMs and their respective stats were listed;
- Then it was possible to "force" the listing of stopped VMs by changing the filter from "All" to "Stopped".
I tested the new listVirtualMachinesUsageHistory API by filtering by different time periods and VMs. All the filtering described in section 2.4 of the spec was successfully tested.

core/src/main/java/com/cloud/agent/api/VmStatsEntry.java

engine/schema/src/main/java/com/cloud/vm/VmStatsVO.java

plugins/metrics/src/main/java/org/apache/cloudstack/api/ListVMsUsageHistoryCmd.java

engine/schema/src/main/java/com/cloud/vm/dao/VmStatsDaoImpl.java

api/src/main/java/org/apache/cloudstack/api/response/StatsResponse.java

api/src/test/java/org/apache/cloudstack/api/response/StatsResponseTest.java

plugins/metrics/src/test/java/org/apache/cloudstack/metrics/MetricsServiceImplTest.java

DaanHoogland · 2022-02-18T13:31:32Z

Looks good @joseflauzino . Can you confirm it is ready for review and testing, please?

joseflauzino · 2022-02-18T13:41:56Z

@DaanHoogland Yes, it's ready.

DaanHoogland · 2022-02-18T14:50:06Z

@blueorangutan package

joseflauzino · 2022-02-22T13:36:10Z

@blueorangutan package

blueorangutan · 2022-02-22T13:37:03Z

@joseflauzino a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-22T14:12:22Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2685

DaanHoogland · 2022-02-22T15:59:19Z

@blueorangutan test

blueorangutan · 2022-02-22T16:00:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-23T01:42:04Z

Trillian test result (tid-3412)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33543 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5984-t3412-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland

cltgm, needs some testing by third party though

DaanHoogland · 2022-02-23T07:45:01Z

@borisstoyanov @rohityadavcloud care to review?

GutoVeronezi

CLGTM, I pointed some minor improvements though.

I'll test it in my local lab and I'll post the results.

api/src/main/java/org/apache/cloudstack/api/ApiArgValidator.java

api/src/main/java/org/apache/cloudstack/api/response/StatsResponse.java

engine/schema/src/main/java/com/cloud/vm/dao/VmStatsDao.java

plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java

server/src/main/java/com/cloud/server/StatsCollector.java

GutoVeronezi · 2022-03-07T19:34:38Z

@blueorangutan package

blueorangutan · 2022-03-07T19:35:03Z

@GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-03-07T20:09:47Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2787

GutoVeronezi · 2022-03-08T17:23:12Z

The tests were performed based on the code changes and the spec (#5935).

I tested the situations with an environment without the changes (ENV-1) and another one with the changes (ENV-2). I separeted the CloudMonkey results in files to avoid posting a big comment.

Situations

✔️ I created a VM, waited for management to gather the information and restarted it. After restart it, ENV-1 was without the informations. ENV-2 had the last collected information.

✔️ I created a VM and verified in two management nodes. ENV-1 presented divergent informations. ENV-2 persented the same information for both nodes.

✔️ I tested some combinations of the global configs:

✔️ UI not showing stopped VMs when seeing metrics unless we filter only stopped:

❌ Analyzing the database, the column vm_stats.mgmt_server_id is storing the node's MacAddress, not the management's id.

@joseflauzino Analyzing the new API's return, I think it would be better if the element stats was ordered by its inner element timestamp.

GutoVeronezi · 2022-04-01T12:36:42Z

@blueorangutan package

blueorangutan · 2022-04-01T12:37:03Z

@GutoVeronezi a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-04-01T13:18:50Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3052

joseflauzino · 2022-04-04T19:16:08Z

@blueorangutan package

blueorangutan · 2022-04-04T19:17:03Z

@joseflauzino a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-04-04T19:52:25Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3071

GutoVeronezi · 2022-04-05T17:44:31Z

I re-ran the manual tests (one of the results below). The feature seems working fine to me.

Test with 15 seconds of interval and 1 minute of retention, with 2 MGMT:

Note: the stats are ordered by the field timestamp now.

(lab) 🐱 > list configurations name=vm.stats
{
  "configuration": [
    {
      "category": "Advanced",
      "description": "When set to 'true', VM metrics(NetworkReadKBs, NetworkWriteKBs, DiskWriteKBs, DiskReadKBs, DiskReadIOs and DiskWriteIOs) that are collected from the hypervisor are summed before being returned.On the other hand, when set to 'false', the VM metrics API will just display the latest metrics collected.",
      "isdynamic": true,
      "name": "vm.stats.increment.metrics",
      "value": "true"
    },
    {
      "category": "Advanced",
      "description": "The interval (in milliseconds) when vm stats are retrieved from agents.",
      "isdynamic": false,
      "name": "vm.stats.interval",
      "value": "15000"
    },
    {
      "category": "Advanced",
      "description": "The maximum time (in minutes) for keeping VM stats records in the database. The VM stats cleanup process will be disabled if this is set to 0 or less than 0.",
      "isdynamic": true,
      "name": "vm.stats.max.retention.time",
      "value": "1"
    }
  ],
  "count": 3
}
(lab) 🐱 > list virtualmachinesusagehistory id=167e5918-4762-4536-a526-942fa2fc62cb 
{
  "count": 1,
  "virtualmachine": [
    {
      "id": "167e5918-4762-4536-a526-942fa2fc62cb",
      "name": "i-2-113-VM",
      "stats": [
        {
          "cpuused": "15.78%",
          "diskiopstotal": 0,
          "diskioread": 0,
          "diskiowrite": 0,
          "diskkbsread": 0,
          "diskkbswrite": 0,
          "memoryintfreekbs": 0,
          "memorykbs": 524288,
          "memorytargetkbs": 524288,
          "networkkbsread": 0,
          "networkkbswrite": 0,
          "networkread": "0.00 MB",
          "networkwrite": "0.00 MB",
          "timestamp": "2022-04-05T17:37:26+0000"
        },
        {
          "cpuused": "16.8%",
          "diskiopstotal": 0,
          "diskioread": 0,
          "diskiowrite": 0,
          "diskkbsread": 0,
          "diskkbswrite": 0,
          "memoryintfreekbs": 0,
          "memorykbs": 524288,
          "memorytargetkbs": 524288,
          "networkkbsread": 0,
          "networkkbswrite": 0,
          "networkread": "0.00 MB",
          "networkwrite": "0.00 MB",
          "timestamp": "2022-04-05T17:37:29+0000"
        },
        {
          "cpuused": "16.08%",
          "diskiopstotal": 0,
          "diskioread": 0,
          "diskiowrite": 0,
          "diskkbsread": 0,
          "diskkbswrite": 0,
          "memoryintfreekbs": 0,
          "memorykbs": 524288,
          "memorytargetkbs": 524288,
          "networkkbsread": 0,
          "networkkbswrite": 0,
          "networkread": "0.00 MB",
          "networkwrite": "0.00 MB",
          "timestamp": "2022-04-05T17:37:41+0000"
        },
        {
          "cpuused": "16.18%",
          "diskiopstotal": 0,
          "diskioread": 0,
          "diskiowrite": 0,
          "diskkbsread": 0,
          "diskkbswrite": 0,
          "memoryintfreekbs": 0,
          "memorykbs": 524288,
          "memorytargetkbs": 524288,
          "networkkbsread": 0,
          "networkkbswrite": 0,
          "networkread": "0.00 MB",
          "networkwrite": "0.00 MB",
          "timestamp": "2022-04-05T17:37:44+0000"
        },
        {
          "cpuused": "16.2%",
          "diskiopstotal": 0,
          "diskioread": 0,
          "diskiowrite": 0,
          "diskkbsread": 0,
          "diskkbswrite": 0,
          "memoryintfreekbs": 0,
          "memorykbs": 524288,
          "memorytargetkbs": 524288,
          "networkkbsread": 0,
          "networkkbswrite": 0,
          "networkread": "0.00 MB",
          "networkwrite": "0.00 MB",
          "timestamp": "2022-04-05T17:37:57+0000"
        },
        {
          "cpuused": "16.88%",
          "diskiopstotal": 0,
          "diskioread": 0,
          "diskiowrite": 0,
          "diskkbsread": 0,
          "diskkbswrite": 0,
          "memoryintfreekbs": 0,
          "memorykbs": 524288,
          "memorytargetkbs": 524288,
          "networkkbsread": 0,
          "networkkbswrite": 0,
          "networkread": "0.00 MB",
          "networkwrite": "0.00 MB",
          "timestamp": "2022-04-05T17:38:00+0000"
        },
        {
          "cpuused": "16.13%",
          "diskiopstotal": 0,
          "diskioread": 0,
          "diskiowrite": 0,
          "diskkbsread": 0,
          "diskkbswrite": 0,
          "memoryintfreekbs": 0,
          "memorykbs": 524288,
          "memorytargetkbs": 524288,
          "networkkbsread": 0,
          "networkkbswrite": 0,
          "networkread": "0.00 MB",
          "networkwrite": "0.00 MB",
          "timestamp": "2022-04-05T17:38:12+0000"
        },
        {
          "cpuused": "14.47%",
          "diskiopstotal": 0,
          "diskioread": 0,
          "diskiowrite": 0,
          "diskkbsread": 0,
          "diskkbswrite": 0,
          "memoryintfreekbs": 0,
          "memorykbs": 524288,
          "memorytargetkbs": 524288,
          "networkkbsread": 0,
          "networkkbswrite": 0,
          "networkread": "0.00 MB",
          "networkwrite": "0.00 MB",
          "timestamp": "2022-04-05T17:38:15+0000"
        }
      ]
    }
  ]
}

The column vm_stats.mgmt_server_id is storing the management server's id now:

MariaDB [cloud]> select * from mshost;
+----+----------------+---------------+-----------------------------+--------------------------------------+-------+-------------------+-----------------+--------------+---------------------+---------+-------------+
| id | msid           | runid         | name                        | uuid                                 | state | version           | service_ip      | service_port | last_update         | removed | alert_count |
+----+----------------+---------------+-----------------------------+--------------------------------------+-------+-------------------+-----------------+--------------+---------------------+---------+-------------+
|  1 | 90520745551922 | 1649179172554 | cloudstack-lab-management-1 | cd30ed1b-daed-4f23-bd5a-439ed609bf13 | Up    | 4.17.0.0-SNAPSHOT | 192.168.201.150 |         9090 | 2022-04-05 17:38:12 | NULL    |           0 |
|  3 | 90520746808830 | 1649179414017 | cloudstack-lab-management-2 | ea6b28f8-8511-43f8-bff7-03a9c3fc01d8 | Up    | 4.17.0.0-SNAPSHOT | 192.168.201.151 |         9090 | 2022-04-05 17:38:11 | NULL    |           0 |
+----+----------------+---------------+-----------------------------+--------------------------------------+-------+-------------------+-----------------+--------------+---------------------+---------+-------------+
2 rows in set (0.001 sec)

MariaDB [cloud]> select * from vm_stats;
+-----+-------+----------------+---------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| id  | vm_id | mgmt_server_id | timestamp           | vm_stats_data                                                                                                                                                                                                                                                                   |
+-----+-------+----------------+---------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| 136 |   113 |              1 | 2022-04-05 17:37:26 | {"vmId":113,"cpuUtilization":15.784281486353175,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"} |
| 137 |   113 |              3 | 2022-04-05 17:37:29 | {"vmId":113,"cpuUtilization":16.801075268817204,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"} |
| 138 |   113 |              1 | 2022-04-05 17:37:41 | {"vmId":113,"cpuUtilization":16.078753076292042,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"} |
| 139 |   113 |              3 | 2022-04-05 17:37:44 | {"vmId":113,"cpuUtilization":16.183412002697235,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"} |
| 140 |   113 |              1 | 2022-04-05 17:37:57 | {"vmId":113,"cpuUtilization":16.203322914953116,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"} |
| 141 |   113 |              3 | 2022-04-05 17:38:00 | {"vmId":113,"cpuUtilization":16.87624090006618,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}  |
| 142 |   113 |              1 | 2022-04-05 17:38:12 | {"vmId":113,"cpuUtilization":16.1276982879828,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}   |
| 143 |   113 |              3 | 2022-04-05 17:38:15 | {"vmId":113,"cpuUtilization":14.468924695823743,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"} |
+-----+-------+----------------+---------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
8 rows in set (0.001 sec)

@nvazquez can we re-run the smoke tests for this one?

nvazquez · 2022-04-06T02:41:16Z

Thanks @GutoVeronezi, sure
@blueorangutan test

blueorangutan · 2022-04-06T02:42:02Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-04-06T14:59:44Z

Trillian test result (tid-3826)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42884 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5984-t3826-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

joseflauzino · 2022-04-08T19:22:28Z

@GutoVeronezi @nvazquez @DaanHoogland
Can we merge this?

DaanHoogland · 2022-04-09T12:27:25Z

At this stage, i'd leave that with the RM, @nvazquez ?

@GutoVeronezi @nvazquez @DaanHoogland Can we merge this?

nvazquez · 2022-04-11T13:40:39Z

@joseflauzino sorry, have deleted my previous comment - have seen its been manually tested - can be merged

rohityadavcloud · 2022-07-12T04:09:13Z

Hi @joseflauzino - does the new API return the exact same API output format/keys as the deprecated listVirtualMachinesMetrics with this PR?

- Changes behaviour of details param handling for: - listVirtualMachines API: when the detail param is not provided, it uses `all` details except `stats` - listVirtualMachinesMetrics API: when the detail param is not provided, it uses `all` details including `stats` - Remove ConfigKey vm.stats.increment.metrics.in.memory which was renamed to `vm.stats.increment.metrics` in apache#5984 - Changes default value of VM stats accumulation setting `vm.stats.increment.metrics` to false until a better solution emerges. Since apache#5984, this is true and during the execution of listVM APIs the stats are clubbed/calculated which can immensely slow down list VM API calls. - Fix UI that uses listVirtualMachinesMetrics to not call `stats` detail when in list view without metrics selected. These changes see 2-4x gains in the listVirtualMachines APIs call and in the UI. For environment where code changes are not possible, disabling `vm.stats.increment.metrics` global setting saw 2-4x speed gain in the list API calls. Signed-off-by: Rohit Yadav <[email protected]>

- Changes behaviour of details param handling via global setting: - listVirtualMachines API: when the details param is not provided, it returns `all` details excluding/including `stats` which is controllable by a new global setting `list.vm.default.details.stats` - listVirtualMachinesMetrics API: when the details param is not provided, it uses `all` details including `stats` - Users who are affected by the stats related change, can have backward compatibility at the higher-cost of listVirtualMachines API response time by setting `list.vm.default.details.stats` to true - Remove ConfigKey vm.stats.increment.metrics.in.memory which was renamed to `vm.stats.increment.metrics` in apache#5984 and also remove unused/unnecessary global settings via upgrade path - Changes default value of VM stats accumulation setting `vm.stats.increment.metrics` to false until a better solution emerges. Since apache#5984, this is true and during the execution of listVM APIs the stats are clubbed/calculated which can immensely slow down list VM API calls. - Fix UI that uses listVirtualMachinesMetrics to not call `stats` detail when in list view without metrics selected. Signed-off-by: Rohit Yadav <[email protected]>

#9177) - Changes behaviour of details param handling via global setting: - listVirtualMachines API: when the details param is not provided, it returns whether stats are returned controlled by a new global setting `list.vm.default.details.stats` - listVirtualMachinesMetrics API: when the details param is not provided, it uses `all` details including `stats` - Users who are affected slow performance of the listVirtualMachines API response time can set `list.vm.default.details.stats` to `false` - Remove ConfigKey vm.stats.increment.metrics.in.memory which was renamed to `vm.stats.increment.metrics` in #5984 and also remove unused/unnecessary global settings via upgrade path - Changes default value of VM stats accumulation setting `vm.stats.increment.metrics` to false until a better solution emerges. Since #5984, this is true and during the execution of listVM APIs the stats are clubbed/calculated which can immensely slow down list VM API calls. Any costly operations such as summing of stats shouldn't be done during the course of a synchronous API, such as the list VM API. - Fix UI that uses listVirtualMachinesMetrics to not call `stats` detail when in list view without metrics selected. Signed-off-by: Rohit Yadav <[email protected]>

apache#9177) - Changes behaviour of details param handling via global setting: - listVirtualMachines API: when the details param is not provided, it returns whether stats are returned controlled by a new global setting `list.vm.default.details.stats` - listVirtualMachinesMetrics API: when the details param is not provided, it uses `all` details including `stats` - Users who are affected slow performance of the listVirtualMachines API response time can set `list.vm.default.details.stats` to `false` - Remove ConfigKey vm.stats.increment.metrics.in.memory which was renamed to `vm.stats.increment.metrics` in apache#5984 and also remove unused/unnecessary global settings via upgrade path - Changes default value of VM stats accumulation setting `vm.stats.increment.metrics` to false until a better solution emerges. Since apache#5984, this is true and during the execution of listVM APIs the stats are clubbed/calculated which can immensely slow down list VM API calls. Any costly operations such as summing of stats shouldn't be done during the course of a synchronous API, such as the list VM API. - Fix UI that uses listVirtualMachinesMetrics to not call `stats` detail when in list view without metrics selected. Signed-off-by: Rohit Yadav <[email protected]>

ravening reviewed Feb 11, 2022

View reviewed changes

core/src/main/java/com/cloud/agent/api/VmStatsEntry.java Show resolved Hide resolved

ravening reviewed Feb 11, 2022

View reviewed changes

engine/schema/src/main/java/com/cloud/vm/VmStatsVO.java Show resolved Hide resolved

ravening reviewed Feb 11, 2022

View reviewed changes

plugins/metrics/src/main/java/org/apache/cloudstack/api/ListVMsUsageHistoryCmd.java Outdated Show resolved Hide resolved

ravening reviewed Feb 11, 2022

View reviewed changes

engine/schema/src/main/java/com/cloud/vm/dao/VmStatsDaoImpl.java Show resolved Hide resolved

nvazquez linked an issue Feb 11, 2022 that may be closed by this pull request

Persistence of VM stats #5935

Closed

nvazquez added this to the 4.17.0.0 milestone Feb 11, 2022

nvazquez added component:management-server type:enhancement labels Feb 11, 2022

DaanHoogland reviewed Feb 14, 2022

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/response/StatsResponse.java Show resolved Hide resolved

DaanHoogland reviewed Feb 14, 2022

View reviewed changes

api/src/test/java/org/apache/cloudstack/api/response/StatsResponseTest.java Show resolved Hide resolved

DaanHoogland reviewed Feb 14, 2022

View reviewed changes

plugins/metrics/src/test/java/org/apache/cloudstack/metrics/MetricsServiceImplTest.java Show resolved Hide resolved

DaanHoogland requested a review from borisstoyanov February 18, 2022 14:50

DaanHoogland approved these changes Feb 23, 2022

View reviewed changes

DaanHoogland added the status:needs-testing label Feb 23, 2022

GutoVeronezi approved these changes Mar 7, 2022

View reviewed changes

GutoVeronezi self-requested a review March 8, 2022 17:17

joseflauzino added 2 commits April 4, 2022 08:48

Resolve conflicts

dbc2b8f

Rerun checks

914ba75

nvazquez approved these changes Apr 11, 2022

View reviewed changes

nvazquez merged commit 16f2896 into apache:main Apr 11, 2022

joseflauzino mentioned this pull request May 20, 2022

VM stats history visualization #6401

Merged

7 tasks

harikrishna-patnala mentioned this pull request Jul 12, 2022

Added deprecated API indication in the API doc #6545

Merged

12 tasks

havengit mentioned this pull request Nov 26, 2023

Vmstats records are not deleted as expected #8266

Closed

BryanMLima mentioned this pull request Dec 13, 2023

Reduce the number of vmstats data saved and improve the response speed of the instance list page #8350

Closed

13 tasks

rohityadavcloud mentioned this pull request Apr 26, 2024

api: improve listVM API handling and response speed #8985

Closed

13 tasks

rohityadavcloud mentioned this pull request Jun 5, 2024

api: listVM API improvement followup, change returning of stats detail #9177

Merged

13 tasks

Persistence of VM stats #5984

Persistence of VM stats #5984

Uh oh!

Conversation

joseflauzino commented Feb 10, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots

New API

UI changes

How Has This Been Tested?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaanHoogland commented Feb 18, 2022

Uh oh!

joseflauzino commented Feb 18, 2022

Uh oh!

DaanHoogland commented Feb 18, 2022

Uh oh!

joseflauzino commented Feb 22, 2022

Uh oh!

blueorangutan commented Feb 22, 2022

Uh oh!

blueorangutan commented Feb 22, 2022

Uh oh!

DaanHoogland commented Feb 22, 2022

Uh oh!

blueorangutan commented Feb 22, 2022

Uh oh!

blueorangutan commented Feb 23, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Feb 23, 2022

Uh oh!

GutoVeronezi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GutoVeronezi commented Mar 7, 2022

Uh oh!

blueorangutan commented Mar 7, 2022

Uh oh!

blueorangutan commented Mar 7, 2022

Uh oh!

GutoVeronezi commented Mar 8, 2022

Situations

Uh oh!

GutoVeronezi commented Apr 1, 2022

Uh oh!

blueorangutan commented Apr 1, 2022

Uh oh!

blueorangutan commented Apr 1, 2022

Uh oh!

joseflauzino commented Apr 4, 2022

Uh oh!

blueorangutan commented Apr 4, 2022

Uh oh!

blueorangutan commented Apr 4, 2022

Uh oh!

GutoVeronezi commented Apr 5, 2022

Uh oh!

nvazquez commented Apr 6, 2022