CLOUDSTACK-8745 : verify usage after root disk migration #713
Conversation
|
cloudstack-pull-rats #342 ABORTED |
|
cloudstack-pull-requests #1037 ABORTED |
|
cloudstack-pull-analysis #274 UNSTABLE |
There was a problem hiding this comment.
There are enableMaintenance and cancelMaintenance methods available now directly from StoragePool in base.py. It's better to use that instead of repeating?
There was a problem hiding this comment.
those methods can be used only with storage pool class object.
There was a problem hiding this comment.
hmm... I thought something like this should work: StoragePool.enableMaintenance(self.api_client, id=storageself.storageid[0][0]) since it is a classmethod
I am just trying to confirm you're using the latest base.py since couple of these enhancements went in recently into base.py...
If it still doesn't fit in, it's ok. You can continue the way you've done
|
test result of enough storage is not available to perform test put storage in maintenance mode and start ha vm and check usage ... SKIP: sufficient storage not available in any cluster for zone 90d85d89-01c4-4a91-b76e-eedf947b40f6 Ran 1 test in 4.059s OK (SKIP=1) |
|
cloudstack-pull-rats #349 ABORTED |
|
cloudstack-pull-analysis #281 ABORTED |
|
LGTM!! |
|
cloudstack-pull-analysis #526 ABORTED |
|
cloudstack-pull-rats #590 ABORTED |
|
The test Looks good to me. |
|
@nitt10prashant please rebase and meld into a single commit |
|
sure |
modified to use maintenance method is base.py and added some more checks CLOUDSTACK-8745: Fail test if list response in empty
nitt10prashant
force-pushed
the
pool_maint
branch
from
198b4b0 to
456abb0
Compare
|
@bhaisaab rebased and merged into single commit ,@swill @koushik-das can you please look into this |
|
I need one more LGTM code review on this one. I will try to test this in my lab today. Thanks... |
|
I think this one is ready unless anyone has any final words... |
CLOUDSTACK-8745 : verify usage after root disk migrationput storage in maintenance mode and start ha vm and check usage ... === TestName: test_ha_with_storage_maintenance | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 1 test in 842.294s OK * pr/713: CLOUDSTACK-8745 : verify usage after root disk migration Signed-off-by: Will Stevens <[email protected]>
Customize link hover color Customize loading color Customize navigation menu color Fixes #712 Fixes #713 Fixes #714 Signed-off-by: Rohit Yadav <[email protected]>
8 participants
put storage in maintenance mode and start ha vm and check usage ... === TestName: test_ha_with_storage_maintenance | Status : SUCCESS ===
ok
Ran 1 test in 842.294s
OK