Feature/systemvm persistent config 4 #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected syntax error in merge.py
2. Added merge routine for guestnetwork config messages 3. Updated test script
This takes the guestnetwork object and also creates an ip object
Give up on using test-kitchen, busser, and more of its complexity and simply run serverspec directly, via SSH.
These files emulate commands coming from cloudstack itself
De Morgans laws chaps The negation of a conjunction is the disjunction of the negations. The negation of a disjunction is the conjunction of the negations.
- when restarting a VPC, the user can check the option Make Redundant in order to change
the VPC offering and make it redundant
Fix rRouter that was deleting the gateway interface
Customise the messages showed during VPC restart based on redundancy Do not show "Make Redundant" option if VPC is already redundant Show on VPC details if a VPC is redundant
Fixed fw rules for a bunch of things Bring public interface up if no tier has been defined
- For redundant VPCs, we should see 2 routers - For single VPCs, we should see 1 router.
- Using the VPC id, it is reliable. - Tested stopping/destroying/creating a router and VRRP is pretty happy
Remove the labels in other languages: Hugo told me there is a team responsible for that
- listVpcNetworks() to be used for the router check task
Fixed issues with real IP and not virtual (gateway) IP being opened on the firewall DNS now works on the vms
- It's taken care by VRRP. wip: clean up where priority is still used.
- once stopped, got to UNKNOWN
Needs to anchore regexp
- If for some reason the cmdLine json doesn't contain the password key, which is almost impossible to happen,
we generate a password based on other unique data per VPC
…since the host will be null any way. Also, there is no need To check either for sanity of duplicate master. Thus, just update the state and get lost.
Contributor
Author
|
It seems I made a mistake with the branch. Will close this one and create a new PR. Cheers, |
rohityadavcloud
added a commit
that referenced
this pull request
Jan 20, 2021
This fixes #35 This fixes #51 This closes #78 This adds the following: - Download iso, template, volume handler to show link - Show VM password on VM start and upon reset password action Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daan,
Latest commits on this branch. Could you please have a look at this pull request?
I will execute all the tests and add the results here. Once it happen, you can create the PR towards master.
Cheers,
Wilder