CLOUDSTACK-8835: Added alerts incase of template download failure #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed-By: Devdeep
Member
|
LGTM |
Contributor
|
Makes sense and LGTM. I see some code duplication in ImageStoreUploadMonitorImpl, though. A good moment to get rid of this? |
Contributor
|
LGTM |
|
cloudstack-pull-rats #577 ABORTED |
|
cloudstack-pull-analysis #513 ABORTED |
Member
Author
|
@DaanHoogland the repeated code is two lines calling sendalert and logger. may be we could move the logging to send alert itself. Will check that later. |
asfgit
pushed a commit
that referenced
this pull request
Sep 14, 2015
CLOUDSTACK-8835: Added alerts incase of template download failureAuthored-By: @sanjaytripathi Reviewed-By: @devdeep * pr/808: CLOUDSTACK-8835: Added alerts incase of template download failure Signed-off-by: Rajani Karuturi <[email protected]>
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
…rage (#808) * compute: add button and modal `take VM volume snapshot` * add awesome camera retro plugins * modified to using component * fix for quiescevm * add quiescevm to api params Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored-By: @sanjaytripathi
Reviewed-By: @devdeep