-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Removed unnecessary @Local annotations and their respective imports #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unnecessary @Local annotations and their respective imports #853
Conversation
|
cloudstack-pull-rats #657 SUCCESS |
|
cloudstack-pull-analysis #606 FAILURE |
|
cloudstack-pull-rats #661 SUCCESS |
|
cloudstack-pull-analysis #610 FAILURE |
|
Hi @critofolini, I think that there was a problem in your PR in class: SecurityGroupManagerImpl |
|
cloudstack-pull-rats #662 SUCCESS |
|
cloudstack-pull-analysis #611 FAILURE |
|
cloudstack-pull-rats #664 SUCCESS |
|
cloudstack-pull-analysis #613 FAILURE |
|
cloudstack-pull-rats #665 SUCCESS |
|
cloudstack-pull-analysis #614 SUCCESS |
|
@cristofolini, could you squash your commits into a single one? |
9e4e17d to
b4c8db4
Compare
|
cloudstack-pull-rats #666 SUCCESS |
|
@rafaelweingartner Done. |
|
cloudstack-pull-analysis #615 SUCCESS |
b4c8db4 to
a5ca762
Compare
…-006 Removed unnecessary @Local annotations and their respective importsFollowing @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports from the ComponentLifecycleBase class and its subclasses seeking a reduction of a few hundred lines of useless code. I had already opened a pull request for this (#853) but at some point my commit disappeared from the PR entirely, showing no new changes in code, which caused it to be merged automatically (with no changes). * pr/1102: Removed unnecessary @Local annotations and their respective imports from the ComponentLifecycleBase class and its subclasses. Signed-off-by: Remi Bergsma <[email protected]>
Following @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports seeking a reduction of a few hundred lines of useless code.