Skip to content

Conversation

@cristofolini
Copy link
Contributor

Following @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports seeking a reduction of a few hundred lines of useless code.

@asfbot
Copy link

asfbot commented Sep 19, 2015

cloudstack-pull-rats #657 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Sep 19, 2015

cloudstack-pull-analysis #606 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Sep 19, 2015

cloudstack-pull-rats #661 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Sep 19, 2015

cloudstack-pull-analysis #610 FAILURE
Looks like there's a problem with this pull request

@rafaelweingartner
Copy link
Member

Hi @critofolini, I think that there was a problem in your PR in class: SecurityGroupManagerImpl

@asfbot
Copy link

asfbot commented Sep 19, 2015

cloudstack-pull-rats #662 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Sep 19, 2015

cloudstack-pull-analysis #611 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Sep 20, 2015

cloudstack-pull-rats #664 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Sep 20, 2015

cloudstack-pull-analysis #613 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Sep 20, 2015

cloudstack-pull-rats #665 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Sep 20, 2015

cloudstack-pull-analysis #614 SUCCESS
This pull request looks good

@rafaelweingartner
Copy link
Member

@cristofolini, could you squash your commits into a single one?

@cristofolini cristofolini force-pushed the master-lrg-cs-hackday-006 branch from 9e4e17d to b4c8db4 Compare September 20, 2015 17:14
@asfbot
Copy link

asfbot commented Sep 20, 2015

cloudstack-pull-rats #666 SUCCESS
This pull request looks good

@cristofolini
Copy link
Contributor Author

@rafaelweingartner Done.

@asfbot
Copy link

asfbot commented Sep 20, 2015

cloudstack-pull-analysis #615 SUCCESS
This pull request looks good

@rafaelweingartner rafaelweingartner force-pushed the master-lrg-cs-hackday-006 branch from b4c8db4 to a5ca762 Compare October 20, 2015 17:47
@asfgit asfgit merged commit a5ca762 into apache:master Oct 21, 2015
asfgit pushed a commit that referenced this pull request Nov 23, 2015
…-006

Removed unnecessary @Local annotations and their respective importsFollowing @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports from the ComponentLifecycleBase class and its subclasses seeking a reduction of a few hundred lines of useless code.

I had already opened a pull request for this (#853) but at some point my commit disappeared from the PR entirely, showing no new changes in code, which caused it to be merged automatically (with no changes).

* pr/1102:
  Removed unnecessary @Local annotations and their respective imports from the ComponentLifecycleBase class and its subclasses.

Signed-off-by: Remi Bergsma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants