CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always displayed rather than the IP corresponding to the NIC where LB is being created #903
Conversation
|
@nitin-maharana Any automated tests for this ? if not, can you spend the time to write some. thanks |
|
@Runseb I think there is no automated tests for this. I will try to write one. Thanks. |
|
@nitin-maharana Any update on this? |
|
@remibergsma I was busy in some other works. Within 3-4 days I will work on this and will give an update. Thank you. |
|
Hi @Runseb @remibergsma I don't understand what to test and how to write a test for this. If you have any idea of how to write one, please help me out. Thanks. |
nitin-maharana
force-pushed
the
nitin1
branch
from
38d9b6a to
834ab53
Compare
…s displayed rather than the IP corresponding to the NIC where LB is being created While calling the listNics API, instead of sending the default nic id as parameter, it should send the network id as a parameter. So, replaced that nicid parameter as networkid parameter.
|
great find @nitin-maharana When I add a LB rule in network isolated2 for the VM, this is API call before the change and it failed. After the fix, it took the right IP and succeeded. 👍 LGTM |
|
Nice small fix, LGTM. |
CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always displayed rather than the IP corresponding to the NIC where LB is being createdWhile calling the listNics API, instead of sending the default nic id as parameter, it should send the network id as a parameter. So, replaced that nicid parameter as networkid parameter. * pr/903: CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always displayed rather than the IP corresponding to the NIC where LB is being created Signed-off-by: Remi Bergsma <[email protected]>
|
Thanks @karuturi @remibergsma. |
Allowing user to use local/browser timezone Signed-off-by: Rohit Yadav <[email protected]>
5 participants
While calling the listNics API, instead of sending the default nic id as parameter, it should send the network id as a parameter.
So, replaced that nicid parameter as networkid parameter.