-
Notifications
You must be signed in to change notification settings - Fork 81
Add V2 endpoints for Foxx Service #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f99d268 to
5cb1b14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds V2 endpoints for Foxx Service management, implementing 20 new Foxx-related API endpoints for operations like service installation, configuration, dependencies, testing, and development mode management.
- Adds comprehensive Foxx service management endpoints to the V2 client
- Refactors existing structures to use generic
FoxxDeploymentOptionsinstead of the specificFoxxCreateOptions - Implements proper error handling and response parsing for various Foxx service operations
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| v2/tests/foxx_test.go | Refactors existing test and adds comprehensive test coverage for all new Foxx service endpoints |
| v2/arangodb/client_foxx_impl.go | Implements all 20 new Foxx service endpoint methods with proper URL construction, request handling, and response parsing |
| v2/arangodb/client_foxx.go | Defines interfaces and data structures for all Foxx service operations including configuration, dependencies, scripts, and development mode |
| v2/CHANGELOG.md | Documents the addition of missing Foxx endpoints to v2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
c6c382c to
7c75e48
Compare
* Foxx: Add GetInstalledFoxxService endpoint to fetch installed Foxx services * Foxx: Add endpoint to fetch detailed information about a specific Foxx service * Foxx: few test scenarios added * Done response code and testcase chages for install and uninstall fox service * Add replace foxx service endpoint * Add upgrade foxx service endpoint * Add endpoint to fetch configuration for a specified foxx service mount * Comments added * Add endpoint to upload configuration options for a specific foxx service * Foxx: Add endpoint for replace foxx service * Foxx: Add endpoint to fetch foxx service dependencies * Foxx: Add endpoint to update foxx service dependencies * Foxx: Add endpoint to replace foxx service dependencies * Foxx: Add endpoints related to fox service scripts * Foxx: Add endpoints for RunFoxServiceScripts Enable and Disable development modes * Foxx: Add endpoint to get fox service readme content * change test case zip file name * Foxx: Add endpoint for swagger fox service * Foxx: Add endpoint to commit local service state * Foxx: Add endpoint to download specific service * changed the zip file path * reverted the zip file path * changes in config * changes in config file * changes in config file * reverted workflows in config file and added resources-path * reverted workflows in config file * trying to from test file that check temp resources is there or not * In config file moved download-demo-data above the run-integration-tests * reverted config changes * Added echo in config file * identation fixed * code changes in config * code changes in config * tag added in changelog * Update v2/tests/foxx_test.go Co-authored-by: Copilot <[email protected]> * ci: trigger CircleCI build * Addressed copilot commets * Addressed copilot comment * Addressed copilot comment for uninstall * Addressed copilot comment for uninstall --------- Co-authored-by: Copilot <[email protected]>
This includes the following Foxx - related endpoints: