Convert Etch components to React components

[smashwilson]

Incrementally complete the conversion from etch to React throughout the codebase. This will be easiest to do if we go top-down, gradually pushing the EtchWrapper boundary further into our component hierarchy.

• controllers/status-bar-tile-controller.js
  • views/branch-view.js
  • views/branch-menu-view.js
  • views/push-pull-view.js
  • views/push-pull-menu-view.js
  • views/changed-files-count-view.js
• controllers/file-patch-controller.js
  • views/file-patch-view.js
    • views/hunk-view.js (HunkView + LineView)
• controllers/git-tab-controller.js
  • views/git-tab-view.js
    • views/staging-view.js
      • views/file-patch-list-item-view.js
      • views/merge-conflict-list-item-view.js
    • controllers/commit-view-controller.js
      • views/commit-view.js

[BinaryMuse]

Thanks for opening this!

For anyone who works on it, be aware that getItem in the Portal based classes will need to be changed since Etch elements can be moved from their prents, but React ones can not. May also require CSS changes.

[BinaryMuse]

Or rather, the use of getItem

[smashwilson]

👍 So noted. I'd guessed that this would be more involved than switching the import and using setState instead of etch.update() 😉

Do you also anticipate problems with React's event handling playing poorly with the Portal stuff? Or should we be okay there because React installs handlers on the document root?

[smashwilson]

Finished! We are now 100% free-range, organic React 🎉