Skip to content

PCBC-960 Merge protostellar branch to master #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Matt-Woz merged 21 commits into from
Nov 14, 2023
Merged

PCBC-960 Merge protostellar branch to master #138

Matt-Woz merged 21 commits into from
Nov 14, 2023

Conversation

@Matt-Woz
Copy link
Contributor

@Matt-Woz Matt-Woz commented Oct 25, 2023

Changes:

  • Added dependencies for PS; PS submodule, GRPC in composer
  • Added PS Autogen script, and autogenerated files in GPBMetadata/ and Couchbase/Protostellar/Generated
  • Added Protostellar implementation files under Couchbase/Protostellar
  • Updated scripts & package.xml
  • Added Cluster logic to use the Protostellar Cluster
  • Interfaces:
    • Added Management interfaces for cross compatibility between Classic and PS
    • Updated tests & data structures to use respective interfaces
  • Misc:
    • Added tests utils for Protostellar, skipped appropriate tests
    • Updated LookupInResult to check for array existence before returning (Protostellar lookupin/data structures tests were not passing without this)

@Matt-Woz Matt-Woz marked this pull request as draft October 25, 2023 17:11
Matt-Woz
Matt-Woz commented Oct 25, 2023
View reviewed changes
Matt-Woz
Matt-Woz commented Oct 25, 2023
View reviewed changes
@Matt-Woz Matt-Woz marked this pull request as ready for review November 9, 2023 17:45
@Matt-Woz Matt-Woz requested a review from avsej November 9, 2023 17:45
@Matt-Woz Matt-Woz merged commit f622abb into couchbase:main Nov 14, 2023
@Matt-Woz Matt-Woz deleted the PCBC-960_merge_protostellar_branch_to_master branch November 14, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avsej avsej avsej approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Matt-Woz @avsej