Skip to content

modules in cwd can't be --omitted #33

@nedbat

Description

@nedbat

Originally reported by Danek Duvall (Bitbucket: dhduvall, GitHub: dhduvall)


I'm having trouble with --omit. The code that we're testing is off in $PROTO, and the test suite itself is in the current directory, in directories "api" and "cli". So I'm running coverage as

    coverage html --omit $PROTO/mod1,$PROTO/mod2,api,cli

but that doesn't actually exclude api and cli from the report. I also tried with $PWD/api,$PWD/cli, but no dice.

In code_unit_factory(), we match cu.name against "prefix", but that prefix has been turned into an absolute pathname, so the .startswith() call doesn't return true, and we end up putting them into the final list.

If we check against cu.filename instead of cu.name, it appears to work correctly, but I'm not sure if that breaks something else.


Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions