[CWG 3] P2796R0 CWG2518 Conformance requirements and #error/#warning #6120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
suggested changes
Feb 16, 2023
jensmaurer
added
the
changes requested
burblebee
force-pushed
the
motions-2023-02-cwg-3
branch
from
3501bab to
7643924
Compare
burblebee
removed
the
changes requested
burblebee
requested review from
JohelEGP and
jensmaurer
and removed request for
JohelEGP
JohelEGP
suggested changes
Feb 22, 2023
JohelEGP
approved these changes
Feb 28, 2023
tkoeppe
force-pushed
the
motions-2023-02-cwg-3
branch
from
99116b3 to
b3886b8
Compare
tkoeppe
reviewed
Mar 5, 2023
source/declarations.tex
Outdated
| or the expression is evaluated in the context of a template definition, | ||
| the declaration has no | ||
| effect. Otherwise, | ||
| %FIXME: What does it mean for a grammar term to fail? Also in [temp.res]/p6. |
Contributor
There was a problem hiding this comment.
Isn't this text the definition of what it means for the static_assert-declaration to fail?
@jensmaurer, any thoughts? I think this seems clear?
Member
There was a problem hiding this comment.
Yes, that's the intent: We defined "fails" here.
Note that the proposed resolution in CWG2518 marks "fails" in italics to highlight the fact this is a term definition.
Contributor
There was a problem hiding this comment.
It's not in italics in this PR. Also, does #6120 (comment), which made "int" into int, makes sense if the error comment is supposed to be a reproduction of the string-literal to the static_assert?
Contributor
There was a problem hiding this comment.
Oh, good catch, we need to italicise fails, thank you!
tkoeppe
force-pushed
the
motions-2023-02-cwg-3
branch
from
b3886b8 to
b334df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6085.
Fixes cplusplus/papers#1366
Fixes cplusplus/papers#1251
Fixes cplusplus/papers#675