Skip to content

Conversation

@fernandezcuesta
Copy link
Contributor

@fernandezcuesta fernandezcuesta commented Aug 13, 2024

Description of your changes

Converting metadata struct to a dict should return a nested dict, rather than a dict with e.g. annotations as a struct.

I have:

Read and followed Crossplane's [contribution process](https://git.io/fj2m9).
- [X] Added or updated unit tests for my change.

@fernandezcuesta
Copy link
Contributor Author

unsure about whether or not we want to keep the previous behaviour as default, while allowing a "recursive" struct_to_dict via an additional argument :/

@bobh66
Copy link
Collaborator

bobh66 commented Aug 13, 2024

unsure about whether or not we want to keep the previous behaviour as default, while allowing a "recursive" struct_to_dict via an additional argument :/

Good question - I tend to think the existing behavior is "wrong" since I would have expected nested translation, but it could be breaking if people are already used to having to convert the child objects. I'd still lean toward changing it though.

@negz any thoughts?

Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I tend to agree this feels more like a bug fix. No need to maintain the old behavior. Thanks!

@negz negz merged commit 6037575 into crossplane:main Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants