This repository was archived by the owner on Dec 17, 2024. It is now read-only.
Prometheus mode optimization #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… collection In async mode metrics are collected as with say Postgres storage, but only the last dataset is kept in memory for each DB+metric pair. General goal of this feature is to support scraping dozens of DBs without timeouts which is impossible in current sync / serial mode.
…ance removed from config
…rom Health-check dash
So that they could be rolled out with the import_all.sh script
similar to PG implementation but with less fields
When restarting Prom scraper pods for a short time there can be 2 pods collecting same data with different labels that can mess up the graphs. Also some other visual adjustments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is non-breaking and add basically a new "--prometheus-async-mode" flag that will enable Prom mode also be used with dozens of instances under monitoring instead of the usual one. When flag is enabled we basically run as normally with Postgres storage but with the difference that nothing is stored but latest metrics cached in memory so that they could immediately presented when a scrape request comes in. Otherwise one would soon start to get timeouts...
Also add some 5 most commonly used dashboards for Prometheus, basically clones of PG ones.