Skip to content

Conversation

@simonetgordon
Copy link
Contributor

@simonetgordon simonetgordon commented Jun 27, 2022

To resolve issue #130

@honno honno self-requested a review June 27, 2022 13:26
@asmeurer
Copy link
Member

This looks good. This probably didn't come up for NumPy because it actually does a mutation, but that is not a requirement of the spec. In Python, x op= y is equivalent to x = x.__iop__(y) (see https://docs.python.org/3/reference/datamodel.html?highlight=__iadd__#object.__iadd__).

@asmeurer asmeurer merged commit ddd3b7a into data-apis:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants