Skip to content

update icon: postcss (original, original-wordmark, plain-wordmark) #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Snailedlt merged 5 commits into from
Nov 25, 2023
Merged

update icon: postcss (original, original-wordmark, plain-wordmark) #2012

Snailedlt merged 5 commits into from
Nov 25, 2023

Conversation

@weh
Copy link
Contributor

@weh weh commented Nov 16, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

  • Replace plain with alias
  • Optimize svgs

This PR closes NONE

Part of #2001

Notes

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team November 16, 2023 12:51
@weh weh mentioned this pull request Nov 16, 2023
Closed
9 tasks
canaleal
canaleal previously approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, LGTM!
By the way, I added a fill to plain-wordmark path to ensure it follows the same format as the other SVGs.

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 18, 2023
@Snailedlt Snailedlt mentioned this pull request Nov 19, 2023
Closed
Snailedlt
Snailedlt requested changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Postcss-original has some weird artifacting that needs to be fixed:
image

Original wordmark looks good though:
image

@weh
Copy link
Contributor Author

weh commented Nov 20, 2023 •
edited
Loading

  • fixed the icon (removed artifacts)
  • rebased to current develop branch

@canaleal sorry, i think i flushed your changes with my force push, can you please check again

@weh weh requested review from Snailedlt and canaleal November 20, 2023 12:02
@Snailedlt
Copy link
Collaborator

Snailedlt commented Nov 20, 2023

@weh Although I love rebasing myself it's not really that useful in devicons, but it can sometimes be hurtful.
In general, try to use merge instead of rebase when fixing PRs, especially after someone has reviewed it since it makes it much easier to see what changed since their last review.

Also we don't really care about a clean git history on feature branches since they are squash-merged into develop anyways, so it always ends up being just 1 commit :)

Snailedlt
Snailedlt requested changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the artifacts are fixed! Excellent work!
However, like you said there are some changes that @canaleal suggested that are missing. I made some new suggestions to hopefully fix those :)

@weh weh requested a review from Snailedlt November 22, 2023 14:11
lunatic-fox
lunatic-fox approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great work! 👍🏼
Thank you for this contribution! 🚀

Snailedlt
Snailedlt approved these changes Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Looks Great! 💯 Thank you for another great PR! 🙇‍♂️

@Snailedlt Snailedlt merged commit 257912d into devicons:develop Nov 25, 2023
@lunatic-fox lunatic-fox mentioned this pull request Jan 10, 2024
Merged
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@weh @Snailedlt
update icon: postcss (original, original-wordmark, plain-wordmark) (d…
1844a99 
…evicons#2012)

* Update postcss icon

* Fix color

* Fix icon

* Update optimized svg

---------

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal

Assignees

No one assigned

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weh @Snailedlt @canaleal @lunatic-fox