update icon: vertx (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canaleal
added
the
feature:icon
lunatic-fox
requested changes
Dec 2, 2023
Contributor
lunatic-fox
left a comment
lunatic-fox
left a comment
There was a problem hiding this comment.
I think we still need the trademark symbol since the official logo has that. 🤔
lunatic-fox
changed the title
Snailedlt
requested changes
Dec 7, 2023
Collaborator
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Looks like you made some typos on the color code for a few of the icons. Other than that it looks great!
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
lunatic-fox
approved these changes
Dec 7, 2023
Contributor
lunatic-fox
left a comment
lunatic-fox
left a comment
There was a problem hiding this comment.
Great work! 👍🏼
And thank you @Snailedlt for noticing the wrong color.
Thank for this contribution! 🚀
Snailedlt
approved these changes
Dec 17, 2023
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
…k, line, line-wordmark) (devicons#2045) * update icon: vertx * Updated wordmark elements * Adjusting icons and create `plain` version * Update icons/vertx/vertx-plain.svg Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Update icons/vertx/vertx-original.svg Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Update icons/vertx/vertx-line.svg Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> --------- Co-authored-by: Josélio de S. C. Júnior <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR is related to #1998
Link to prove your SVG is correct and up-to-date.
Additional Notes
Some wordmarks have the TM (Trade Mark) text; I went with the version without the TX.
The purple color
#782a90was used for the font SVGs.