Skip to content

update icon: vyper (original, original-wordmark) #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Snailedlt merged 7 commits into from
Sep 13, 2024
Merged

update icon: vyper (original, original-wordmark) #2221

Snailedlt merged 7 commits into from
Sep 13, 2024

Conversation

@itsacoyote
Copy link
Contributor

@itsacoyote itsacoyote commented Jun 17, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

Updates Vyper logo to latest branding design.
https://vyperlang.org/

Notes

Removed vyper-plain and vyper-plain-wordmark.
Updated vyper-original and vyper-original-wordmark and added aliases to cover plain.

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jul 1, 2024
@Snailedlt Snailedlt requested review from a team, ConX, Snailedlt, canaleal, lunatic-fox and weh and removed request for a team July 1, 2024 06:50
canaleal
canaleal requested changes Jul 27, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great work!

All that's left is to optimize the SVGs and add "original-wordmark" to the SVG and Font entries inside the devicon.json file.

@itsacoyote
Copy link
Contributor Author

itsacoyote commented Jul 30, 2024

Overall, great work!

All that's left is to optimize the SVGs and add "original-wordmark" to the SVG and Font entries inside the devicon.json file.

Thanks for the suggestions! I tried to find as much of the documentation to make sure I was following things correctly, but had trouble finding the little bits. I'll make those changes 👍🏻

@itsacoyote itsacoyote requested a review from canaleal July 31, 2024 14:28
weh
weh previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, images are optimized. 👍

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@itsacoyote itsacoyote requested a review from weh September 11, 2024 14:11
Snailedlt
Snailedlt approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✔️
Thank you for the contribution! 🚀

@Snailedlt
Copy link
Collaborator

Snailedlt commented Sep 12, 2024

@ConX @canaleal please re-review this PR when you have time

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt merged commit 9774e8a into devicons:develop Sep 13, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@itsacoyote @canaleal
update icon: vyper (original, original-wordmark) (devicons#2221)
e0faabe 
* update vyper icon

* adjust vyper logos

* Removed double paths

* re-order devicon.json for vyper alphabetically

---------

Co-authored-by: canaleal <[email protected]>
Co-authored-by: Alex Canales <[email protected]>
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@canaleal canaleal canaleal approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

@weh weh Awaiting requested review from weh

Assignees

No one assigned

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@itsacoyote @Snailedlt @weh @canaleal