-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: dyalog (original, original-wordmark) #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
weh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
canaleal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@gewaleelek The D and DYALOG are for the company. The product has the cube. Here are the latest versions of all three (we've cleaned them up and darkened the orange a bit). |
|
@abrudz should these two be used for the product then, or just the first one? Do you have any mono-colored versions of the one with the box in th background? If not we'll need to make one so it can be used for the font |
|
Great, thank you! |
The previously suggested icons were for the company, while these new ones are for the product as explained here: devicons#2356 (comment) Co-authored-by: abrudz <[email protected]>
|
I made a new PR to use the product logos instead. Let me know if there are any issues with it :) |



Double check these details before you open a PR
developbranch.devicon.jsonfile at the correct alphabetic position as seen hereThis PR closes #254
Link to prove your SVG is correct and up-to-date.
Note: the request #254 uses the "cube" background behind the D, which can be found in here and here, but it does not seem to be as prominent as the simple "D" and "Dyalog". Do let me know if you think I should use that instead.