Skip to content

Conversation

@gewaleelek
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #254

Link to prove your SVG is correct and up-to-date.

Note: the request #254 uses the "cube" background behind the D, which can be found in here and here, but it does not seem to be as prominent as the simple "D" and "Dyalog". Do let me know if you think I should use that instead.

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team February 12, 2025 09:36
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent stuff. SVGs look great and there are no weird artifacts in icomoon.

image

@canaleal canaleal merged commit e97fbc6 into devicons:develop Feb 12, 2025
5 checks passed
@gewaleelek gewaleelek deleted the dyalog branch February 16, 2025 15:19
@abrudz
Copy link

abrudz commented Jun 10, 2025

@gewaleelek The D and DYALOG are for the company. The product has the cube. Here are the latest versions of all three (we've cleaned them up and darkened the orange a bit).
dyalog-ide-cube-2025

dyalog-logo-2025_orange

D Orange

@Snailedlt
Copy link
Collaborator

@abrudz should these two be used for the product then, or just the first one?
image
image

Do you have any mono-colored versions of the one with the box in th background? If not we'll need to make one so it can be used for the font

@abrudz
Copy link

abrudz commented Jun 10, 2025

If for just the product, use only the D-cube. (You're welcome to add the company logos too, if you want.)

Here's a mono-colored version:

dyalog-ide-cube-2025 2-MONO

@Snailedlt
Copy link
Collaborator

Great, thank you!
For now, company logos is out of scope for the devicon icon library, but maybe in the future :)

Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Jun 10, 2025
The previously suggested icons were for the company, while these new ones are for the product as explained here: devicons#2356 (comment)

Co-authored-by: abrudz <[email protected]>
@Snailedlt
Copy link
Collaborator

I made a new PR to use the product logos instead. Let me know if there are any issues with it :)

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Jun 24, 2025
@canaleal canaleal mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants