Skip to content

Conversation

@Finii
Copy link
Contributor

@Finii Finii commented May 7, 2025

[why]
The plain/line item contains two lines that are not visible in the original icon. Technically they are there but they are hidden. These lines make it impossible to recognize the stylized N that is the basis of the icon.

[how]
Take the rounded hexagon from the eps file (because it was the most clean one) and hand draw the lines of the N. Create from that simple form all the new plain/line icons.

Use a different stroke thickness for the wordmark icons because the previously used line width is ridiculously thin.

Images

Left: current, right: suggested new form

plain

image

line

image

plain wordmark

image

line wordmark

image

original for reference

image

This has been suggested by @Snailedlt here: #2011 (comment)

(Hope I got all the names, branches, and bits and pieces right this time 😬 )

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Finii
Copy link
Contributor Author

Finii commented May 7, 2025

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Dear SVG-Checker Bot, I did not even touch that file, and it is exactly sorted as it is in master. As I added no new icons that means that either your checking algorithm is wrong, or that some maintainer pulled an 'invalid' devicon.json into master.
Anyhow, I can do nothing about anything here, I'm sorry.

@Snailedlt
Copy link
Collaborator

Please ignore the check bot. We have a PR that should fix it, but for now it is kinda broken :/

Snailedlt
Snailedlt previously approved these changes May 7, 2025
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Finii !
Thank you for suggesting and fixing this issue! ❤️

The only thing I would suggest to improve the icons is to move the fill up before the path, so that it is a bit easier to see the diff and maintain it, but it's not a big enough deal to warrant non-approval.

Great work as always! ✅

@Snailedlt Snailedlt added feature:icon PR when a new icon is ready to be added to the collection bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels May 7, 2025
@Snailedlt Snailedlt requested review from a team, ConX, canaleal, lunatic-fox and weh and removed request for a team May 7, 2025 10:29
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

[why]
The plain/line item contains two lines that are not visible in the
original icon. Technically they are there but they are hidden.
These lines make it impossible to recognize the stylized N that is the
basis of the icon.

[how]
Take the rounded hexagon from the wps file (because it was the most
clean one) and hand draw the lines of the N. Create from that simple
form all the new plain/line icons.

Use a different stroke thickness for the wordmark icons because the
previously used line width is ridiculously thin.

After optimized export from Inkscape hand-edit file to re-sort elements,
remove unused fill attributes and make start identical to previous svgs.

Signed-off-by: Fini Jastrow <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Finii
Copy link
Contributor Author

Finii commented May 7, 2025

The only thing I would suggest to improve the icons is to move the fill up before the path, so that it is a bit easier to see the diff and maintain it, but it's not a big enough deal to warrant non-approval.

Whatever, that is simple. Just changed the files in an editor and re-used the 'preamble' of the svgs in the repo instead of 'stock inkscape' (see commit message).

👍

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt merged commit 0876dff into devicons:develop Jun 2, 2025
5 checks passed
@canaleal canaleal mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:check Trigger check-bot. Remove and re-add the label to re-trigger bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants