-
Notifications
You must be signed in to change notification settings - Fork 2.4k
update icon: npm (original, original-wordmark, plain) #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
| "plain" | ||
| ], | ||
| "font": [ | ||
| "original", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is still a npm-original.svg file in the folder. why do you want to delete this entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the original icon is multi-colored so it can't be used as a font.
One of the requirements for our font is that the icons are mono-colored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry did not realize that this is the "font" object.
Yes you are right.
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
| "plain" | ||
| ], | ||
| "font": [ | ||
| "original", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry did not realize that this is the "font" object.
Yes you are right.
Double check these details before you open a PR
developbranch.devicon.jsonfile at the correct alphabetic position as seen hereResolves Build error for 2.17.0
#2436