Skip to content

Conversation

@canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

Resolves Build error for 2.17.0

#2436

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Jun 22, 2025
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

The PR's base branch is `draft-release-2.17.0`, but should be `develop`
Please change the PR so that it's based on, and merged into `develop`

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal requested review from a team, ConX, ReenigneArcher, Snailedlt, lunatic-fox and weh and removed request for a team June 22, 2025 04:53
"plain"
],
"font": [
"original",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a npm-original.svg file in the folder. why do you want to delete this entry?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the original icon is multi-colored so it can't be used as a font.
One of the requirements for our font is that the icons are mono-colored

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry did not realize that this is the "font" object.
Yes you are right.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

"plain"
],
"font": [
"original",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry did not realize that this is the "font" object.
Yes you are right.

@canaleal canaleal merged commit 1121c53 into draft-release-2.17.0 Jun 23, 2025
2 checks passed
@canaleal canaleal mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants