Skip to content

new icon: OCaml (original, original-wordmark, plain, plain-wordmark) #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amacado merged 12 commits into from
Feb 21, 2021
Merged

new icon: OCaml (original, original-wordmark, plain, plain-wordmark) #502

amacado merged 12 commits into from
Feb 21, 2021

Conversation

@Panquesito7
Copy link
Member

@Panquesito7 Panquesito7 commented Feb 21, 2021 •
edited
Loading

I added an icon for the OCaml programming language.
original was taken from the https://icon-icons.com/es/icono/ocaml-logotipo/170902 website. original-wordmark was taken and slightly modified from Wikipedia. plain was taken from the https://icon-icons.com/es/icono/ocaml-logotipo/145019 website. plain-wordmark was taken and slightly modified from ocaml/ocaml-logo#2 (comment).

All the images were resized using the resize-image tool. 🙂
This is how they look:

Original OCaml icon Plain OCaml icon Original wordmark OCaml icon Plain wordmark OCaml icon

If I missed up anything, please let me know. Thank you.

@Panquesito7 Panquesito7 mentioned this pull request Feb 21, 2021
Closed
@github-actions

This comment has been minimized.

Sign in to view
@amacado amacado added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection labels Feb 21, 2021
@github-actions

This comment has been minimized.

Sign in to view
amacado
amacado requested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run some optimisations to reduce file size. I used https://www.svgviewer.dev/ as well as some manual editing. Please see the results :)

@amacado
Copy link
Member

amacado commented Feb 21, 2021

As you can see in the screenshots posted by our bot, the plain-wordmark variant looks not the way it should look like. Maybe you can rework it? :)

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2021

Hi!
I'm Devicons' SVG-Checker Bot and I just checked all the SVGs in this branch.

Everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@Panquesito7
Copy link
Member Author

Panquesito7 commented Feb 21, 2021

As you can see in the screenshots posted by our bot, the plain-wordmark variant looks not the way it should look like. Maybe you can rework it? :)

The only thing to do is to remove the white background, right?

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2021

Hi!
I'm Devicons' SVG-Checker Bot and I just checked all the SVGs in this branch.

Everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@github-actions

This comment has been minimized.

Sign in to view
@amacado amacado added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Feb 21, 2021
amacado
amacado requested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a strange, orange line and the "orange" between the legs is missing in icons/ocaml/ocaml-original-wordmark.svg
image

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

![Peeked Icons (top left)](Imgur Images)

Here are the zoomed-in screenshots of the added icons:
Imgur Images\nImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@devicons devicons deleted a comment from github-actions bot Feb 21, 2021
@Panquesito7
Copy link
Member Author

Panquesito7 commented Feb 21, 2021

There is a strange, orange line and the "orange" between the legs is missing in icons/ocaml/ocaml-original-wordmark.svg
image

I think those were caused by your changes? Let me try to fix it, or shall we use the previous version?

@amacado amacado removed the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Feb 21, 2021
@Panquesito7
Copy link
Member Author

Panquesito7 commented Feb 21, 2021

Working on it now.

@Panquesito7 Panquesito7 requested a review from amacado February 21, 2021 21:42
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Panquesito7 Panquesito7 mentioned this pull request Feb 21, 2021
Closed
@Panquesito7
Copy link
Member Author

Panquesito7 commented Feb 21, 2021

Issues have been fixed.

@devicons devicons deleted a comment from github-actions bot Feb 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2021

Hi!
I'm Devicons' SVG-Checker Bot and I just checked all the SVGs in this branch.

Everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@amacado amacado added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Feb 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

![Peeked Icons (top left)](Imgur Images)

Here are the zoomed-in screenshots of the added icons:
Imgur Images\nImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

amacado
amacado approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray! OCaml will be part of our next release! Thanks for contributing @Panquesito7!

@amacado amacado merged commit fe8e365 into devicons:develop Feb 21, 2021
@Panquesito7 Panquesito7 deleted the icons/ocaml branch February 21, 2021 22:09
@amacado amacado mentioned this pull request Feb 21, 2021
Merged
4 tasks
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Panquesito7 @amacado
new icon: OCaml (original, original-wordmark, plain, plain-wordmark) (d…
90bce34 
…evicons#502)

* new icon: OCaml (original, original-wordmark, plain, plain-wordmark)

* Update icons/ocaml/ocaml-plain-wordmark.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Update icons/ocaml/ocaml-plain.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Update icons/ocaml/ocaml-original.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Update icons/ocaml/ocaml-original-wordmark.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Remove white background in ocaml-plain-wordmark

* Fixed errors with original-wordmark

* Remove white background in original icon

* Optimize original-wordmark

* Fix issue reported by GitHub Actions

Co-authored-by: Clemens Bastian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amacado amacado amacado approved these changes

Assignees

No one assigned

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Panquesito7 @amacado